-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontenberg PHP Fatal Errors in Jetpack 6.7 via missing Jetpack_React_Page #10558
Labels
[Focus] Blocks
Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack
[Type] Bug
When a feature is broken and / or not performing as intended
Milestone
Comments
tomjn
added
[Focus] Blocks
Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack
[Type] Bug
When a feature is broken and / or not performing as intended
labels
Nov 7, 2018
CC @Automattic/poseidon |
tomjn
changed the title
Frontenberg Fatal Errors in Jetpack via Jetpack_React_Page
Frontenberg PHP Fatal Errors in Jetpack 6.7 via missing Jetpack_React_Page
Nov 7, 2018
We only need the React page class for |
When working on this, we should also resolve #10495 to knock out two birds with one stone. |
jeherve
pushed a commit
that referenced
this issue
Nov 9, 2018
…activated (#10566) Fixes #10548 Fixes #10495 Fixes #10558 #### Changes proposed in this Pull Request: * Instead of using `get_initial_state()` to shorthand how we get module activation data for block visibility this PR manually builds the needed data. * `get_initial_state()` calls `get_modules` from `Jetpack_Core_API_Module_List_Endpoint` which doesn't respect module activation and [includes modules files](https://github.com/Automattic/jetpack/blame/496bebd5b1890666afe4fc79f52fd94353d88539/_inc/lib/class.core-rest-api-endpoints.php#L2813) which enqueues JS files ¯\_(ツ)_/¯ #### Testing instructions: * Follow the steps in #10548 * Ideally you wont see any JS errors #### Proposed changelog entry for your changes: * Fixes an issue where deactivating ATD causes the post editor to throw JS errors
jeherve
pushed a commit
that referenced
this issue
Nov 9, 2018
…activated (#10566) Fixes #10548 Fixes #10495 Fixes #10558 #### Changes proposed in this Pull Request: * Instead of using `get_initial_state()` to shorthand how we get module activation data for block visibility this PR manually builds the needed data. * `get_initial_state()` calls `get_modules` from `Jetpack_Core_API_Module_List_Endpoint` which doesn't respect module activation and [includes modules files](https://github.com/Automattic/jetpack/blame/496bebd5b1890666afe4fc79f52fd94353d88539/_inc/lib/class.core-rest-api-endpoints.php#L2813) which enqueues JS files ¯\_(ツ)_/¯ #### Testing instructions: * Follow the steps in #10548 * Ideally you wont see any JS errors #### Proposed changelog entry for your changes: * Fixes an issue where deactivating ATD causes the post editor to throw JS errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Focus] Blocks
Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack
[Type] Bug
When a feature is broken and / or not performing as intended
An update to Jetpack
v6.7
has broken frontenberg, causing the following PHP fatal error:I have corrected the issue by modifying
class.jetpack-gutenberg.php
on line 208 to include aclass_exists
check, which brought the site back, but I do not know what excluding this will have broken.I'm expecting that
Jetpack_React_Page
is only loaded ifis_admin
is true, which is not the case in frontenberg and its child themesThe text was updated successfully, but these errors were encountered: