AtD / Gutenberg: request is made to AtD when module is deactivated #10548
Assignees
Labels
[Feature] AtD
[Focus] Blocks
Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack
[Pri] BLOCKER
[Type] Bug
When a feature is broken and / or not performing as intended
Milestone
Comments
jeherve
added
[Type] Bug
|
It appears to be limited to WP 5.0 Beta 3; it does not happen with the Gutenberg plugin. |
jeherve
pushed a commit
that referenced
this issue
Nov 9, 2018
…activated (#10566) Fixes #10548 Fixes #10495 Fixes #10558 #### Changes proposed in this Pull Request: * Instead of using `get_initial_state()` to shorthand how we get module activation data for block visibility this PR manually builds the needed data. * `get_initial_state()` calls `get_modules` from `Jetpack_Core_API_Module_List_Endpoint` which doesn't respect module activation and [includes modules files](https://github.com/Automattic/jetpack/blame/496bebd5b1890666afe4fc79f52fd94353d88539/_inc/lib/class.core-rest-api-endpoints.php#L2813) which enqueues JS files ¯\_(ツ)_/¯ #### Testing instructions: * Follow the steps in #10548 * Ideally you wont see any JS errors #### Proposed changelog entry for your changes: * Fixes an issue where deactivating ATD causes the post editor to throw JS errors
jeherve
pushed a commit
that referenced
this issue
Nov 9, 2018
…activated (#10566) Fixes #10548 Fixes #10495 Fixes #10558 #### Changes proposed in this Pull Request: * Instead of using `get_initial_state()` to shorthand how we get module activation data for block visibility this PR manually builds the needed data. * `get_initial_state()` calls `get_modules` from `Jetpack_Core_API_Module_List_Endpoint` which doesn't respect module activation and [includes modules files](https://github.com/Automattic/jetpack/blame/496bebd5b1890666afe4fc79f52fd94353d88539/_inc/lib/class.core-rest-api-endpoints.php#L2813) which enqueues JS files ¯\_(ツ)_/¯ #### Testing instructions: * Follow the steps in #10548 * Ideally you wont see any JS errors #### Proposed changelog entry for your changes: * Fixes an issue where deactivating ATD causes the post editor to throw JS errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce the issue
You'll notice a JavaScript error:
Setting
add_filter( 'jetpack_gutenberg', '__return_false' );solves the problem, as the AtD scripts are then no longer loaded.The text was updated successfully, but these errors were encountered: