PHP 8.0 and PHPCS: partly fix compatibility with composer packages #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htdat
commented
May 11, 2021
|
|
||
| $DIR/../vendor/bin/diffFilter --phpcs $DIFF_FILE $PHPCS_FILE 0 | ||
| $DIR/../vendor/bin/diffFilter --phpcs $DIFF_FILE $PHPCS_FILE 100 |
There was a problem hiding this comment.
With the previous value 0, this test will never yell exit with an error status. Therefore, we can not recognize issues when running CI.
Ref: https://github.com/exussum12/coverageChecker#usage
htdat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fix #638
Close #647
Description
masterbranch), and (2) it will show errors when diff lines do not conform with PHPCS. Currently, it does not exit with any error.Steps to Test
Mainly check the relevant GitHub Actions for PHP Tests here.
Note: for PHP 8.0 test failure, it will be addressed in another PR as the solution is here #639 (comment)