Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.0 - PHPCS tests - incompatibility with exussum12/coverage-checker #647

Closed
htdat opened this issue May 14, 2021 · 0 comments · Fixed by #643
Closed

PHP 8.0 - PHPCS tests - incompatibility with exussum12/coverage-checker #647

htdat opened this issue May 14, 2021 · 0 comments · Fixed by #643
Assignees
@htdat
Labels
Bug

Comments

@htdat
Copy link
Member

htdat commented May 14, 2021

Summary

From https://github.com/Automattic/Edit-Flow/runs/2407816247?check_suite_focus=true

PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /home/runner/work/Edit-Flow/Edit-Flow/vendor/exussum12/coverage-checker/src/ArgParser.php on line 25

As mentioned in #638 (comment), this can be resolved by giving more version options for exussum12/coverage-checker like the following:

^0.11.2 || ^1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@htdat htdat

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PHP 8.0 and PHPCS: partly fix compatibility with composer packages Automattic/Edit-Flow
1 participant
@htdat