Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shore diff command broken #76

Closed
1 task done
dkirillov opened this issue May 4, 2023 · 1 comment
Closed
1 task done

shore diff command broken #76

dkirillov opened this issue May 4, 2023 · 1 comment
Labels
bug Something isn't working diff Related to "shore diff" Shore-CLI Related to the Shore-CLI visualization layer (the CLI itself)

Comments

@dkirillov
Copy link
Collaborator

dkirillov commented May 4, 2023

Pre Requisites

Description

The shore diff command is currently broken due to this line:

settingsBytes, err := config.LoadConfig(d.Project, "render", renderValues)

The arg order for config.LoadConfig is wrong. This causes the following error when shore diff is ran:

╰─ shore diff 
failed to decode flag as either JSON or filepath with errors:
{2 errors occurred:
  * could not decode JSON - 'render' - Read: unexpected value type: 0, error found in #0 byte of ...|render|..., bigger context ...|render|...
  * could not find file - 'render'

}

Steps to Reproduce

  1. Run shore diff against any working/rendering project.

Expected behavior:

shore diff works and shows if there's any difference.

Actual behavior:

shore diff errors out - error mentioned above.

Reproduces how often:

100% of the time

Versions

v0.0.10 and prior.

Additional Information

N/A

@dkirillov dkirillov added the bug Something isn't working label May 4, 2023
@dkirillov dkirillov added Shore-CLI Related to the Shore-CLI visualization layer (the CLI itself) diff Related to "shore diff" labels May 5, 2023
dkirillov added a commit that referenced this issue May 11, 2023
- fixed the use of config.LoadConfig
@dkirillov
Copy link
Collaborator Author

dkirillov commented May 17, 2023

Fix was released in v0.0.11 and has been confirmed to work by the affected user(s).

Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working diff Related to "shore diff" Shore-CLI Related to the Shore-CLI visualization layer (the CLI itself)
Projects
None yet
Development

No branches or pull requests

1 participant