Ignore usdGeom doubleSided parameter #2099 #2100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
WIP changes to ignore UsdGeom doubleSided. I'm keeping the old code for now, in case we wan't a global parameter to control this behaviour. I found out that the render delegate wasn't supporting the parameter
arnold:sidednessas it does for visibility, so I added this feature.19 tests had to be updated, for often small changes where the new render is more correct than the previous, where some rays would go through parts of the geometry to directly hit the background
test_0026 had 2 single-sided planes where only one was visible and the other was turned in the opposite direction. I added an explicit sidedness to 0 in order to keep the same render and exercise this parameter.
Issues fixed in this pull request
Fixes #2099