Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change fov computation in the procedural to match hydra #2087

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Change fov computation in the procedural to match hydra #2087

merged 2 commits into from
Sep 3, 2024

Conversation

cpichard
Copy link
Collaborator

@cpichard cpichard commented Sep 3, 2024

Changes proposed in this pull request

  • In the procedural we used GfCamera::GetFieldOfView to compute the field of view, but using a similar formula in hydra gives small difference as hydra multiplies the aperture and focal by a constant which reduce the precision. Unfortunately there is no way to get the original values in hydra, so we compute the procedural fov using the projection matrix since the projection computation is the same between hydra and the procedural.
  • This fixes test_1306

Issues fixed in this pull request
Fixes #2086

@cpichard cpichard marked this pull request as ready for review September 3, 2024 11:19
@cpichard cpichard merged commit b068f4c into Autodesk:master Sep 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienblor sebastienblor sebastienblor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FOV computation difference between hydra and the procedural
2 participants
@cpichard @sebastienblor