Minor fixes for ScopeSimple #510
Conversation
teutoburg
force-pushed
the
scopesimple-3
branch
from
50cca91
to
bd8839d
Compare
teutoburg
force-pushed
the
scopesimple-3
branch
from
bd8839d
to
d98f349
Compare
|
Nevermind the two force pushes, that was a silly messup... |
|
This is rather straightforward so I'll just merge it as soon as the docs build passes... |
Or maybe without that. RTD seems to have some issues today, but this shouldn't affect the docs anyway... |
| @@ -268,10 +269,11 @@ def plot(self, img_slice=None, adjust_scale=False, **kwargs): | |||
| " create an uneven image plot.") | |||
|
|
|||
| vminmax = self._get_vminmax(adjust_scale) | |||
| fig_kwargs = kwargs.pop("fig_kwargs", {}) | |||
There was a problem hiding this comment.
I'm going to suggest this anyway: I think it would be better to just add fig_kwargs as an optional parameter to the function instead of popping it from kwargs. As far as I'm aware, there is no good argument for doing it this way; or am I missing something?
There was a problem hiding this comment.
Yeah I did that first, but then there would be fig_kwargs followed by "normal" **kwargs (which go into the plot but not the figure), and also we'd need a default, but dict is mutable so need to use None, then need another line if fig_kwargs is None and so on. But maybe I should have done that rather than this intransparent implicit kwarg-popping. I'll probably change at some point...
Required for #496