-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup example notebooks #496
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
- Coverage 77.16% 77.04% -0.12%
==========================================
Files 66 66
Lines 8207 8204 -3
==========================================
- Hits 6333 6321 -12
- Misses 1874 1883 +9 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
01e60fe
to
462b053
Compare
06710f7
to
003e1fc
Compare
Remove package download Use scopesimple interface for examples
This is the scopesimple couterpart to load_example_optical_train.
This was clashing with tqdm.auto, producing ugly double progress bars.
9b16874
to
0d770a1
Compare
This should make the docs build fail if there are any errors in the notebooks, which used to just go silent in the past. This should allow us to catch them sooner...
Looks good! I haven't experimented yet with the ScopeSimple mode. I think these are a bit too short: data_lfoa = lfoa(source, dit=10, ndit=360)[1].data I would prefer to have the |
IIRC there's also an example in the docs that shows the HDUL as an in-between step, mentioning that it can be saved to disk. |
Just clone the IRDB into the docs build, seems to work fine (after two days of frustrating debugging). Using the scopesimple interface will ensure the relevant packages are downloaded in the absence of the clone (yes I tested that locally).
Sorry for the force push mess, at some point I forgot there's already a PR for this...
RTD page is far from being perfect, but probably as good as we will get it before the workshop...