Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use price #1356

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fix use price #1356

merged 1 commit into from
Jul 12, 2024

Conversation

gtg7784
Copy link
Member

@gtg7784 gtg7784 commented Jul 12, 2024

Pull Request Summary

To avoid big number error, enable immediate only for H160 address in usePrice hooks

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Changes

  • only enable immediate for h160 address

@gtg7784 gtg7784 changed the base branch from main to release-hotfix July 12, 2024 13:27
Copy link

Visit the preview URL for this PR (updated for commit 95928df):

https://astar-apps--pr1356-fix-use-price-attto88f.web.app

(expires Fri, 19 Jul 2024 13:35:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@gtg7784 gtg7784 requested review from bobo-k2 and impelcrypto July 12, 2024 14:27
@impelcrypto impelcrypto merged commit 5ba2cc0 into release-hotfix Jul 12, 2024
9 checks passed
@impelcrypto impelcrypto deleted the fix-use-price branch July 12, 2024 17:23
bobo-k2 added a commit that referenced this pull request Jul 19, 2024
* disable celer bridge (#1353)

* disable cbridge

* fix statement shorter

* disable celer bridge icon too (#1354)

* Fix usePrice hooks (#1355)

* fix usePrice issue

* refactor, just using immediate is enough

* only enable immediate for h160 wallet (#1356)

* Fetch account identity fix (#1359)

---------

Co-authored-by: Taegeon Alan Go <[email protected]>
bobo-k2 added a commit that referenced this pull request Aug 11, 2024
* disable celer bridge (#1353)

* disable cbridge

* fix statement shorter

* disable celer bridge icon too (#1354)

* Fix usePrice hooks (#1355)

* fix usePrice issue

* refactor, just using immediate is enough

* only enable immediate for h160 wallet (#1356)

* Add metadata hash and uplift to polkadot 12.0.1

* Added // @ts-nocheck to ignore some typing errors for now

* More // @ts-nocheck

* WithSignedTransaction

* Remove hash

* $api removed

* fix: removed useLedger and login toggle (#1371)

---------

Co-authored-by: Taegeon Alan Go <[email protected]>
Co-authored-by: Roy <[email protected]>
bobo-k2 added a commit that referenced this pull request Aug 16, 2024
* hotfix: enable xcm with Bifrost (#1361)

* Fix ledger on the portal (#1370)

* disable celer bridge (#1353)

* disable cbridge

* fix statement shorter

* disable celer bridge icon too (#1354)

* Fix usePrice hooks (#1355)

* fix usePrice issue

* refactor, just using immediate is enough

* only enable immediate for h160 wallet (#1356)

* Add metadata hash and uplift to polkadot 12.0.1

* Added // @ts-nocheck to ignore some typing errors for now

* More // @ts-nocheck

* WithSignedTransaction

* Remove hash

* $api removed

* fix: removed useLedger and login toggle (#1371)

---------

Co-authored-by: Taegeon Alan Go <[email protected]>
Co-authored-by: Roy <[email protected]>

* Add raw metadata to chain info (#1372)

* Add raw metadata to chain info

* Enable users to update metadata once more event if it is up to date

* Polkadot types errors fix (#1373)

* Fix polkadot types errors

* Be strict

* Polkasafe version update

---------

Co-authored-by: Roy <[email protected]>
Co-authored-by: Taegeon Alan Go <[email protected]>
impelcrypto added a commit that referenced this pull request Aug 21, 2024
* hotfix: enable xcm with Bifrost (#1361)

* Fix ledger on the portal (#1370)

* disable celer bridge (#1353)

* disable cbridge

* fix statement shorter

* disable celer bridge icon too (#1354)

* Fix usePrice hooks (#1355)

* fix usePrice issue

* refactor, just using immediate is enough

* only enable immediate for h160 wallet (#1356)

* Add metadata hash and uplift to polkadot 12.0.1

* Added // @ts-nocheck to ignore some typing errors for now

* More // @ts-nocheck

* WithSignedTransaction

* Remove hash

* $api removed

* fix: removed useLedger and login toggle (#1371)

---------

Co-authored-by: Taegeon Alan Go <[email protected]>
Co-authored-by: Roy <[email protected]>

* Add raw metadata to chain info (#1372)

* Add raw metadata to chain info

* Enable users to update metadata once more event if it is up to date

* Polkadot types errors fix (#1373)

* Fix polkadot types errors

* Be strict

* Polkasafe version update

* Fix for getting dApps (#1374)

---------

Co-authored-by: Roy <[email protected]>
Co-authored-by: Taegeon Alan Go <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants