disable celer bridge #1353
Merged
disable celer bridge #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 8b0790b): https://astar-apps--pr1353-disable-cbridge-ifq5wzey.web.app (expires Thu, 18 Jul 2024 14:05:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
gtg7784
requested review from
impelcrypto,
bobo-k2,
codespool,
ayumitk and
Kahonnohak
bobo-k2
reviewed
Jul 11, 2024
| @@ -241,6 +244,10 @@ export default defineComponent({ | |||
| return isH160.value && (isAstar.value || isAstarZkEvm.value); | |||
| }); | |||
|
|
|||
| const isEnableCelerBridge = computed<boolean>(() => { | |||
There was a problem hiding this comment.
You can make this statemen shoreter
const isEnableCelerBridge = computed<boolean>(() => false);
There was a problem hiding this comment.
Yes, thank you! fixed in 8b0790b commit
bobo-k2
approved these changes
Jul 11, 2024
bobo-k2
added a commit
that referenced
this pull request
Jul 19, 2024
* disable celer bridge (#1353) * disable cbridge * fix statement shorter * disable celer bridge icon too (#1354) * Fix usePrice hooks (#1355) * fix usePrice issue * refactor, just using immediate is enough * only enable immediate for h160 wallet (#1356) * Fetch account identity fix (#1359) --------- Co-authored-by: Taegeon Alan Go <[email protected]>
bobo-k2
added a commit
that referenced
this pull request
Aug 11, 2024
* disable celer bridge (#1353) * disable cbridge * fix statement shorter * disable celer bridge icon too (#1354) * Fix usePrice hooks (#1355) * fix usePrice issue * refactor, just using immediate is enough * only enable immediate for h160 wallet (#1356) * Add metadata hash and uplift to polkadot 12.0.1 * Added // @ts-nocheck to ignore some typing errors for now * More // @ts-nocheck * WithSignedTransaction * Remove hash * $api removed * fix: removed useLedger and login toggle (#1371) --------- Co-authored-by: Taegeon Alan Go <[email protected]> Co-authored-by: Roy <[email protected]>
bobo-k2
added a commit
that referenced
this pull request
Aug 16, 2024
* hotfix: enable xcm with Bifrost (#1361) * Fix ledger on the portal (#1370) * disable celer bridge (#1353) * disable cbridge * fix statement shorter * disable celer bridge icon too (#1354) * Fix usePrice hooks (#1355) * fix usePrice issue * refactor, just using immediate is enough * only enable immediate for h160 wallet (#1356) * Add metadata hash and uplift to polkadot 12.0.1 * Added // @ts-nocheck to ignore some typing errors for now * More // @ts-nocheck * WithSignedTransaction * Remove hash * $api removed * fix: removed useLedger and login toggle (#1371) --------- Co-authored-by: Taegeon Alan Go <[email protected]> Co-authored-by: Roy <[email protected]> * Add raw metadata to chain info (#1372) * Add raw metadata to chain info * Enable users to update metadata once more event if it is up to date * Polkadot types errors fix (#1373) * Fix polkadot types errors * Be strict * Polkasafe version update --------- Co-authored-by: Roy <[email protected]> Co-authored-by: Taegeon Alan Go <[email protected]>
impelcrypto
added a commit
that referenced
this pull request
Aug 21, 2024
* hotfix: enable xcm with Bifrost (#1361) * Fix ledger on the portal (#1370) * disable celer bridge (#1353) * disable cbridge * fix statement shorter * disable celer bridge icon too (#1354) * Fix usePrice hooks (#1355) * fix usePrice issue * refactor, just using immediate is enough * only enable immediate for h160 wallet (#1356) * Add metadata hash and uplift to polkadot 12.0.1 * Added // @ts-nocheck to ignore some typing errors for now * More // @ts-nocheck * WithSignedTransaction * Remove hash * $api removed * fix: removed useLedger and login toggle (#1371) --------- Co-authored-by: Taegeon Alan Go <[email protected]> Co-authored-by: Roy <[email protected]> * Add raw metadata to chain info (#1372) * Add raw metadata to chain info * Enable users to update metadata once more event if it is up to date * Polkadot types errors fix (#1373) * Fix polkadot types errors * Be strict * Polkasafe version update * Fix for getting dApps (#1374) --------- Co-authored-by: Roy <[email protected]> Co-authored-by: Taegeon Alan Go <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Check list
This pull request makes the following changes:
Fixes