-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add async XCM contract call scenario #941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks. Not a pallet-contract expert so I basically skipped the contract impl part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds the test - which is good!
Question - how will the non-runtime devs, or to be more precise, how will the smart contract devs know about this feature?
@Dinonard EDIT: Sorry I miss understood, I thought you meant the build script.
|
Minimum allowed line rate is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Summary
Add Async XCM contract call experimental scenario to xcm-simulator tests.
NOTE
Based on #939This PR adds,
ink! contract PoC for async call to be used as fixture in testsAsync XCM Contract Call
call_runtime
to perform some operation (likeTransact
).Transact
instr will be used to send an XCM back to ParaA which will call ERROR contract method.Check list