Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve XCM simulator fixtures #939

Closed
wants to merge 4 commits into from
Closed

feat: improve XCM simulator fixtures #939

wants to merge 4 commits into from

Conversation

ashutoshvarma
Copy link
Member

Pull Request Summary
Improve the contract fixtures handling in xcm simulator tests by introducing cargo build script to compile ink! contracts on the fly.

  • Introduced new cargo build script to build ink! contracts on fly.
  • Remove precompiled Wasm blob (not required since they will be generated before tests)

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

@ashutoshvarma ashutoshvarma added the tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc. label May 19, 2023
@ashutoshvarma ashutoshvarma mentioned this pull request May 25, 2023
Merged
5 tasks
Dinonard
Dinonard reviewed May 30, 2023
View reviewed changes
tests/xcm-simulator/Cargo.toml Show resolved Hide resolved
tests/xcm-simulator/build.rs Show resolved Hide resolved
tests/xcm-simulator/build.rs Show resolved Hide resolved
tests/xcm-simulator/build.rs Show resolved Hide resolved
tests/xcm-simulator/contracts/flipper/Cargo.toml Show resolved Hide resolved
tests/xcm-simulator/contracts/flipper/Cargo.toml Show resolved Hide resolved
@ashutoshvarma
Copy link
Member Author

Closing this as we decided not to include this in runtime codebase.
Build script along with contracts move to https://github.com/AstarNetwork/ink-test-contracts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinonard Dinonard Dinonard left review comments

@shaunxw shaunxw Awaiting requested review from shaunxw

@gitofdeepanshu gitofdeepanshu Awaiting requested review from gitofdeepanshu

Assignees
No one assigned
Labels
tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashutoshvarma @Dinonard