Burn 20% of fees in shibuya (same as shiden) #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akru
force-pushed
the
feature/shibuya-burn-fees
branch
from
f3fcd8f to
86babdc
Compare
Maar-io
reviewed
Nov 22, 2021
runtime/shibuya/src/lib.rs
Outdated
|
|
||
| // burn part of fees | ||
| let burned = Balances::burn(to_burn.peek()); | ||
| assert!( |
There was a problem hiding this comment.
can you use error instead of assert?
There was a problem hiding this comment.
Unfortunately we can’t, but we can escape of using assert here
akru
force-pushed
the
feature/shibuya-burn-fees
branch
from
86babdc to
1cd329c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Check list
This pull request makes the following changes:
Adds
Fixes
Changes
To-dos