Burn 20% of fees in shibuya (same as shiden) (#516)

AstarNetwork · Nov 23, 2021 · 8324d79 · 8324d79
1 parent 0bbb23f
commit 8324d79
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/runtime/shibuya/src/lib.rs b/runtime/shibuya/src/lib.rs
@@ -7,7 +7,7 @@
 use codec::{Decode, Encode};
 use frame_support::{
     construct_runtime, parameter_types,
-    traits::{Contains, Currency, FindAuthor, Imbalance, OnUnbalanced},
+    traits::{Contains, Currency, FindAuthor, Imbalance, OnUnbalanced, SameOrOther},
     weights::{
         constants::{BlockExecutionWeight, ExtrinsicBaseWeight, WEIGHT_PER_SECOND},
         DispatchClass, Weight, WeightToFeeCoefficient, WeightToFeeCoefficients,
@@ -85,7 +85,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
     spec_name: create_runtime_str!("shibuya"),
     impl_name: create_runtime_str!("shibuya"),
     authoring_version: 1,
-    spec_version: 19,
+    spec_version: 20,
     impl_version: 0,
     apis: RUNTIME_API_VERSIONS,
     transaction_version: 1,
@@ -528,8 +528,13 @@ impl OnUnbalanced<NegativeImbalance> for DealWithFees {
             if let Some(tips) = fees_then_tips.next() {
                 tips.merge_into(&mut fees);
             }
+            let (to_burn, collators) = fees.ration(20, 80);
+
+            // burn part of fees
+            let _ = Balances::burn(to_burn.peek());
+
             // pay fees to collators
-            <ToStakingPot as OnUnbalanced<_>>::on_unbalanced(fees);
+            <ToStakingPot as OnUnbalanced<_>>::on_unbalanced(collators);
         }
     }
 }

diff --git a/runtime/shiden/src/lib.rs b/runtime/shiden/src/lib.rs
@@ -84,7 +84,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
     spec_name: create_runtime_str!("shiden"),
     impl_name: create_runtime_str!("shiden"),
     authoring_version: 1,
-    spec_version: 29,
+    spec_version: 30,
     impl_version: 0,
     apis: RUNTIME_API_VERSIONS,
     transaction_version: 1,
@@ -530,11 +530,7 @@ impl OnUnbalanced<NegativeImbalance> for DealWithFees {
             let (to_burn, collators) = fees.ration(20, 80);
 
             // burn part of fees
-            let burned = Balances::burn(to_burn.peek());
-            assert!(
-                matches!(burned.offset(to_burn), SameOrOther::None),
-                "fees burn check"
-            );
+            let _ = Balances::burn(to_burn.peek());
 
             // pay fees to collators
             <ToStakingPot as OnUnbalanced<_>>::on_unbalanced(collators);