-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XCM Update #1043
XCM Update #1043
Conversation
/bench astar-dev pallet_xcm |
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/6453476552. |
Benchmarks have been finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about reserve_transfer_assets
usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the usage of reserve_transfer_assets
from parachain calls in tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more substantial comments, but we need to discuss first whether to block old calls immediately or later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot about this one in runtime .toml
files:
# TODO: remove this once we get rid of `pallet-xcm` fork & double dep
polkadot-runtime = { workspace = true, optional = true }
Please remove this now.
Minimum allowed line rate is |
Pull Request Summary
This PR is in continuation with #996 and updates
xcm precompile
andpallet-xcm
Issue - #1037
Changes
transfer
function of xcm precompilepallet-xcm
and use the officialpallet-xcm
by Parity.To Do
reserve_withdraw_assets
from testspallet_xcm
transfer calls block ( removed from this PR, will be done later)Check list