Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Question Types #181

Merged
merged 13 commits into from
Apr 21, 2024
Merged

Added Question Types #181

merged 13 commits into from
Apr 21, 2024

Conversation

Raulms29
Copy link
Contributor

Now it's possible to provide a type attribute on the /questions endpoint, so it'll only return questions of that type.
I also added a new endpoint that when called returns a list of all the possible types.

@Raulms29 Raulms29 linked an issue Apr 20, 2024 that may be closed by this pull request
Add Question Types #179
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 20, 2024
View reviewed changes
questionservice/src/services/question-generator.ts Dismissed Show dismissed Hide dismissed
questionservice/src/services/question-generator.ts Dismissed Show dismissed Hide dismissed
@Raulms29 Raulms29 closed this Apr 20, 2024
@Raulms29 Raulms29 reopened this Apr 20, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

didierrc
didierrc approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@didierrc didierrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good! As talked internally, types seems to be a "simple" addition yet powerful. I'll approve this PR once OpenAPI is updated with the correct info and the new endpoint to know the types of Questions. Good job

Raulms29 added 5 commits April 21, 2024 16:31
@Raulms29
Updateed OpenAPI with new endpoint
0ee8e8a
@Raulms29
Added a new template and fixed a bug.
f5373dd 
It was possible to obtain a question which had 2 answers that were the same, but one of them was labeled as incorrect, That is no longer possible
@Raulms29
Added 2 more Templates
ba67ed7
@Raulms29
Removed Code duplication error
4eb696b
@Raulms29
Added a couple more sports templates
8ca38ab
@Raulms29 Raulms29 self-assigned this Apr 21, 2024
codescene-delta-analysis[bot]

This comment was marked as outdated.

Sign in to view

@didierrc
Copy link
Contributor

As stated before, I'll just merge it.

@didierrc didierrc merged commit cdf954a into master Apr 21, 2024
2 of 3 checks passed
@Raulms29 Raulms29 mentioned this pull request Apr 30, 2024
Closed
@didierrc didierrc mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didierrc didierrc didierrc approved these changes

@codescene-delta-analysis codescene-delta-analysis[bot] codescene-delta-analysis[bot] approved these changes

Assignees

@Raulms29 Raulms29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Question Types
2 participants
@Raulms29 @didierrc