Added Some Question Templates #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible to obtain a question which had 2 answers that were the same, but one of them was labeled as incorrect, That is no longer possible
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| wikidataResponse, | ||
| randomIndexes | ||
| ); | ||
| let answersArray: object[] = []; |
There was a problem hiding this comment.
ℹ Getting worse: Primitive Obsession
The ratio of primitive types in function arguments increases from 46.43% to 46.67%, threshold = 30.0%
| @@ -172,6 +172,21 @@ describe("Question Service - Question Generator", () => { | |||
| checkAllFieldsWithoutImage(response); | |||
| }) | |||
|
|
|||
| it("should return 1 question with all correct when there are repeated answers", async () => { | |||
There was a problem hiding this comment.
ℹ Getting worse: Code Duplication
introduced similar code in: "should return 1 question with all correct when there are repeated answers",mockWikidataSparqlRepeated
|
didierrc
approved these changes
Apr 21, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.