Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: windows builds #1843

Merged
merged 9 commits into from
Mar 17, 2020
Merged

fix: windows builds #1843

merged 9 commits into from
Mar 17, 2020

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Mar 16, 2020 •
edited
Loading

Summary

electron-builder was signing windows builds with the Apple certificate. This removes the use of the said certificate

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. Status: In Progress The issue or pull request is being worked on. labels Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 16, 2020 •
edited
Loading

Codecov Report

Merging #1843 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1843   +/-   ##
========================================
  Coverage    60.08%   60.08%           
========================================
  Files          369      369           
  Lines         9200     9200           
  Branches      1883     1883           
========================================
  Hits          5528     5528           
  Misses        3484     3484           
  Partials       188      188

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507e99e...cb361b9. Read the comment docs.

@alexbarnsley alexbarnsley marked this pull request as ready for review March 17, 2020 15:21
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Mar 17, 2020
@alexbarnsley alexbarnsley changed the title [WIP] fix: windows builds fix: windows builds Mar 17, 2020
@faustbrian faustbrian merged commit 62dee43 into develop Mar 17, 2020
@ghost ghost deleted the fix/non-mac-build-signing branch March 17, 2020 15:33
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Mar 17, 2020
@alexbarnsley alexbarnsley mentioned this pull request Mar 18, 2020
Closed
@ghost ghost mentioned this pull request Mar 22, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian faustbrian approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@luciorubeens luciorubeens Awaiting requested review from luciorubeens

Assignees
No one assigned
Labels
Complexity: Medium Less than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexbarnsley @faustbrian