This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 190
refactor: adjust bridgechain transaction form validation #1730
Merged
alexbarnsley
merged 13 commits into
ArkEcosystem:develop
from
dated:refactor/bridgechain-validation
Feb 28, 2020
Merged
refactor: adjust bridgechain transaction form validation #1730
alexbarnsley
merged 13 commits into
ArkEcosystem:develop
from
dated:refactor/bridgechain-validation
Feb 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dated
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
luciorubeens
as code owners
February 27, 2020 10:53
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
added
Complexity: Medium
Less than 256 lines changed.
Type: Refactor
The pull request improves or enhances an existing implementation.
labels
Feb 27, 2020
dated
changed the title
refactor: adjust bridgechain transaction form validation
[WIP] refactor: adjust bridgechain transaction form validation
Feb 27, 2020
dated
changed the title
[WIP] refactor: adjust bridgechain transaction form validation
refactor: adjust bridgechain transaction form validation
Feb 27, 2020
alexbarnsley
approved these changes
Feb 28, 2020
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
ghost
added
the
Status: Member Approved
The pull request has been approved by a member.
label
Feb 28, 2020
alexbarnsley
added
Bounty: Tier 4
Awarded for small features, refactorings, improvements. This is valued at 20 USD.
Bounty: Tier 3
Awarded for medium features, refactorings, improvements. This is valued at 50 USD.
and removed
Bounty: Tier 4
Awarded for small features, refactorings, improvements. This is valued at 20 USD.
labels
Feb 28, 2020
Your pull request has been merged and marked as tier 3. It will earn you $50 USD. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Bounty: Tier 3
Awarded for medium features, refactorings, improvements. This is valued at 50 USD.
Complexity: Medium
Less than 256 lines changed.
Status: Member Approved
The pull request has been approved by a member.
Type: Refactor
The pull request improves or enhances an existing implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes:
required
error message toname
,genesisHash
andbridgechainRepository
upon registrationFixes:
tooShort
validation on bridgechain updatesVALIDATION.TOO_MANY
error on the seed node inputChecklist