Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: adjust business transaction form validation #1736

Merged
merged 16 commits into from
Mar 9, 2020
Merged

refactor: adjust business transaction form validation #1736

merged 16 commits into from
Mar 9, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Feb 28, 2020

Summary

Similar to #1730, but for business transactions.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Feb 28, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Feb 28, 2020
@alexbarnsley alexbarnsley added Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Bounty: Tier 3 Awarded for medium features, refactorings, improvements. This is valued at 50 USD. and removed Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. labels Mar 1, 2020
@dated dated changed the title refactor: adjust business transaction form validation [WIP] refactor: adjust business transaction form validation Mar 3, 2020
@dated dated changed the title [WIP] refactor: adjust business transaction form validation refactor: adjust business transaction form validation Mar 3, 2020
@ghost
Copy link

ghost commented Mar 9, 2020

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Mar 9, 2020
@alexbarnsley alexbarnsley merged commit ee97098 into ArkEcosystem:develop Mar 9, 2020
@ghost
Copy link

ghost commented Mar 9, 2020

Your pull request has been merged and marked as tier 3. It will earn you $50 USD.

@dated dated deleted the refactor/business-validation branch March 9, 2020 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 3 Awarded for medium features, refactorings, improvements. This is valued at 50 USD. Complexity: Medium Less than 256 lines changed. Status: Member Approved The pull request has been approved by a member. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants