Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-logger-pino): show log levels <= defined threshold level #3681

Merged
merged 3 commits into from
May 5, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented May 5, 2020

Summary

Show log levels <= defined threshold level, as our custom levels are defined from higher 0 "emergency" to lower 7 "debug".

So that if I define the threshold as "info" / 6, I want everything below or equal to 6 to be shown (higher levels), and everything above to be hidden (lower levels).

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #3681 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3681   +/-   ##
========================================
  Coverage    91.33%   91.33%           
========================================
  Files          536      536           
  Lines        12503    12503           
  Branches      1553     1553           
========================================
  Hits         11420    11420           
  Misses        1082     1082           
  Partials         1        1           
Impacted Files Coverage Δ
packages/core-logger-pino/src/driver.ts 91.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8434157...b83f149. Read the comment docs.

@faustbrian faustbrian merged commit e1921ba into develop May 5, 2020
@ghost ghost deleted the fix/pino-levels branch May 5, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants