fix(core-logger-pino): show log levels <= defined threshold level (#3681

)
ArkEcosystem · May 5, 2020 · e1921ba · e1921ba
1 parent 8434157
commit e1921ba
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 10 deletions.
diff --git a/__tests__/e2e/lib/config/nodes/core0/.env b/__tests__/e2e/lib/config/nodes/core0/.env
@@ -1,5 +1,5 @@
 CORE_P2P_PEER_VERIFIER_DEBUG_EXTRA=true
-CORE_LOG_LEVEL=emergency
+CORE_LOG_LEVEL=debug
 CORE_LOG_LEVEL_FILE=trace
 
 CORE_DB_PORT=5432

diff --git a/__tests__/e2e/lib/config/nodes/core1/.env b/__tests__/e2e/lib/config/nodes/core1/.env
@@ -1,5 +1,5 @@
 CORE_P2P_PEER_VERIFIER_DEBUG_EXTRA=true
-CORE_LOG_LEVEL=emergency
+CORE_LOG_LEVEL=debug
 CORE_LOG_LEVEL_FILE=trace
 
 CORE_DB_PORT=5432

diff --git a/__tests__/e2e/lib/config/nodes/core2/.env b/__tests__/e2e/lib/config/nodes/core2/.env
@@ -1,5 +1,5 @@
 CORE_P2P_PEER_VERIFIER_DEBUG_EXTRA=true
-CORE_LOG_LEVEL=emergency
+CORE_LOG_LEVEL=debug
 CORE_LOG_LEVEL_FILE=trace
 
 CORE_DB_PORT=5432

diff --git a/__tests__/e2e/lib/config/nodes/core3/.env b/__tests__/e2e/lib/config/nodes/core3/.env
@@ -1,5 +1,5 @@
 CORE_P2P_PEER_VERIFIER_DEBUG_EXTRA=true
-CORE_LOG_LEVEL=emergency
+CORE_LOG_LEVEL=debug
 CORE_LOG_LEVEL_FILE=trace
 
 CORE_DB_PORT=5432

diff --git a/__tests__/e2e/lib/config/nodes/core4/.env b/__tests__/e2e/lib/config/nodes/core4/.env
@@ -1,5 +1,5 @@
 CORE_P2P_PEER_VERIFIER_DEBUG_EXTRA=true
-CORE_LOG_LEVEL=emergency
+CORE_LOG_LEVEL=debug
 CORE_LOG_LEVEL_FILE=trace
 
 CORE_DB_PORT=5432

diff --git a/__tests__/unit/core-logger-pino/driver.test.ts b/__tests__/unit/core-logger-pino/driver.test.ts
@@ -21,8 +21,8 @@ beforeEach(async () => {
 
     logger = await app.resolve<Logger>(PinoLogger).make({
         levels: {
-            console: process.env.CORE_LOG_LEVEL || "emergency",
-            file: process.env.CORE_LOG_LEVEL_FILE || "emergency",
+            console: process.env.CORE_LOG_LEVEL || "debug",
+            file: process.env.CORE_LOG_LEVEL_FILE || "debug",
         },
         fileRotator: {
             interval: "1d",

diff --git a/packages/core-logger-pino/src/defaults.ts b/packages/core-logger-pino/src/defaults.ts
@@ -1,7 +1,7 @@
 export const defaults = {
     levels: {
-        console: process.env.CORE_LOG_LEVEL || "emergency",
-        file: process.env.CORE_LOG_LEVEL_FILE || "emergency",
+        console: process.env.CORE_LOG_LEVEL || "info",
+        file: process.env.CORE_LOG_LEVEL_FILE || "info",
     },
     fileRotator: {
         interval: "1d",

diff --git a/packages/core-logger-pino/src/driver.ts b/packages/core-logger-pino/src/driver.ts
@@ -237,7 +237,7 @@ export class PinoLogger implements Contracts.Kernel.Logger {
                 try {
                     const json = JSON.parse(chunk);
 
-                    if (getLevel(json.level) >= getLevel(level)) {
+                    if (getLevel(json.level) <= getLevel(level)) {
                         const line: string | undefined = pinoPretty(json);
 
                         if (line !== undefined) {