Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-magistrate-crypto): export only namespaces #2980

Merged
merged 3 commits into from
Sep 30, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Sep 28, 2019

Summary

Export top level namespaces for Transactions and Enums.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #2980 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2980      +/-   ##
===========================================
- Coverage    66.02%   66.01%   -0.01%     
===========================================
  Files          420      420              
  Lines        10046    10044       -2     
  Branches       511      511              
===========================================
- Hits          6633     6631       -2     
  Misses        3371     3371              
  Partials        42       42
Impacted Files Coverage Δ
...es/core-api/src/handlers/businesses/transformer.ts 50% <ø> (ø) ⬆️
.../core-api/src/handlers/bridgechains/transformer.ts 50% <ø> (ø) ⬆️
...transactions/src/handlers/business-registration.ts 70.96% <100%> (ø) ⬆️
...-transactions/src/handlers/business-resignation.ts 58.06% <100%> (ø) ⬆️
...trate-transactions/src/handlers/business-update.ts 30% <100%> (-1.71%) ⬇️
...te-transactions/src/handlers/bridgechain-update.ts 25.49% <100%> (-1.44%) ⬇️
...nsactions/src/handlers/bridgechain-registration.ts 72.5% <100%> (ø) ⬆️
...ansactions/src/handlers/bridgechain-resignation.ts 51.21% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2323c4d...b37e8e0. Read the comment docs.

@spkjp spkjp merged commit 43db49c into develop Sep 30, 2019
@ghost ghost deleted the refactor/core-magistrate-crypto/exports branch September 30, 2019 21:38
vasild added a commit that referenced this pull request Oct 1, 2019
…ts-nonce

* ArkEcosystem/core/develop:
  fix(deps): update dependency @hapi/boom to v8 (#2988)
  feat(crypto): allow passing height to `configManager.isNewMilestone` (#3001)
  ci: update branch patterns to new format
  refactor: remove asset migration heuristic (#2999)
  chore(deps): update dependency typesync to ^0.6.0 (#2981)
  refactor(core): use default heap size regardless of available memory (#2998)
  chore(deps): update dependency cross-env to v6 (#2985)
  chore(deps): update dependency rimraf to v3 (#2987)
  refactor: core-magistrate-crypto export namespaces (#2980)
  feat: multiSignWif (#2979)
  fix(core-snapshots): export/import transactions' type_group (#2996)
  chore(deps): update dependency @types/newrelic to v5 (#2984)
  fix(deps): update dependency node-forge to ^0.9.0 (#2983)
  feat(core-api): find htlc unlock transactions (#2976)
  chore(deps): update dependency del-cli to v3 (#2986)
  fix(deps): update dependency cli-progress to v3 (#2990)
  fix(deps): update dependency winston-daily-rotate-file to v4 (#2992)
  fix(core-api): missing orderBy (#2974)
  feat(core): allow CLI command configurations (#2972)
  refactor(core-magistrate):  Split core-marketplace into core-magistrate-crypto and core-magistrate-transactions (#2967)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant