Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): missing orderBy #2974

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Sep 27, 2019

Summary

Accept orderBy on /locks and /wallet/{id}/locks.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #2974 into develop will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2974      +/-   ##
===========================================
+ Coverage    68.19%   68.25%   +0.05%     
===========================================
  Files          420      420              
  Lines        10015    10016       +1     
  Branches       508      509       +1     
===========================================
+ Hits          6830     6836       +6     
+ Misses        3145     3139       -6     
- Partials        40       41       +1
Impacted Files Coverage Δ
...re-database/src/repositories/utils/sort-entries.ts 93.75% <ø> (ø) ⬆️
packages/core-api/src/handlers/wallets/methods.ts 96.42% <ø> (+7.14%) ⬆️
packages/core-api/src/handlers/wallets/schema.ts 100% <ø> (ø) ⬆️
...kages/core-api/src/handlers/wallets/transformer.ts 83.33% <0%> (-16.67%) ⬇️
...se/src/repositories/wallets-business-repository.ts 58.57% <100%> (ø) ⬆️
...ackages/core-api/src/handlers/locks/transformer.ts 100% <100%> (ø) ⬆️
...ckages/core-api/src/handlers/wallets/controller.ts 70% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bccf66...b5ffc8d. Read the comment docs.

@faustbrian faustbrian merged commit 16591dd into develop Sep 28, 2019
@ghost ghost deleted the fix/core-api/locks-orderBy branch September 28, 2019 02:40
vasild added a commit that referenced this pull request Oct 1, 2019
…ts-nonce

* ArkEcosystem/core/develop:
  fix(deps): update dependency @hapi/boom to v8 (#2988)
  feat(crypto): allow passing height to `configManager.isNewMilestone` (#3001)
  ci: update branch patterns to new format
  refactor: remove asset migration heuristic (#2999)
  chore(deps): update dependency typesync to ^0.6.0 (#2981)
  refactor(core): use default heap size regardless of available memory (#2998)
  chore(deps): update dependency cross-env to v6 (#2985)
  chore(deps): update dependency rimraf to v3 (#2987)
  refactor: core-magistrate-crypto export namespaces (#2980)
  feat: multiSignWif (#2979)
  fix(core-snapshots): export/import transactions' type_group (#2996)
  chore(deps): update dependency @types/newrelic to v5 (#2984)
  fix(deps): update dependency node-forge to ^0.9.0 (#2983)
  feat(core-api): find htlc unlock transactions (#2976)
  chore(deps): update dependency del-cli to v3 (#2986)
  fix(deps): update dependency cli-progress to v3 (#2990)
  fix(deps): update dependency winston-daily-rotate-file to v4 (#2992)
  fix(core-api): missing orderBy (#2974)
  feat(core): allow CLI command configurations (#2972)
  refactor(core-magistrate):  Split core-marketplace into core-magistrate-crypto and core-magistrate-transactions (#2967)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants