GCS_MAVLink: allow uploading GCS to cancel upload using mission_clear_all #27854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/missionitemprotocol-clear-all-is-zero-item-upload
branch
from
0e1077f
to
5c6a2b2
Compare
peterbarker
changed the title
tridge
requested changes
Aug 19, 2024
allow reuse of this logic
in the same way that we allow a link to re-start an upload by sending mission_count, allow a GCS to clear a mission and cancel current upload if it was the one doing the transfer
peterbarker
force-pushed
the
pr/missionitemprotocol-clear-all-is-zero-item-upload
branch
from
5c6a2b2
to
5e2d8b1
Compare
peterbarker
deleted the
pr/missionitemprotocol-clear-all-is-zero-item-upload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these would appear to be identical operations.clear differs from a 0-item-upload in the "clear" is only allowed disarmed, and resets a whole bunch of mission state (e.g. the loaded item).Replaces #15669 . Like the PR it replaces, this allows a GCS to cancel an upload with a clear-all command as if they'd issues a mission-upload with zero items.