Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ifdefs to remove more code around RC option code #27777

Merged
merged 5 commits into from
Sep 7, 2024

Conversation

peterbarker
Copy link
Contributor

Moves us closer to being able to remove default: clauses.

Board               AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
Durandal                       *      *           *       *                 *      *      *
KakuteH7-bdshot                *      *           *       *                 *      *      *
MatekF405                      -16    *           -56     -48               -40    -16    -8
Pixhawk1-1M-bdshot             -16                -16     -16               -16    -16    -16
f303-Universal      *
iomcu                                                           *
revo-mini                      -8     *           -8      -8                -16    -8     -16

real    5m21.096s
user    133m52.460s
sys     18m32.352s

@peterbarker peterbarker force-pushed the pr/rc-channel-ifdefs branch 5 times, most recently from 7ca2b91 to 8631074 Compare August 7, 2024 05:46
@tridge
Copy link
Contributor

tridge commented Aug 7, 2024

@peterbarker please test code size on AP_Periph targets too before merge, thanks!

@peterbarker peterbarker force-pushed the pr/rc-channel-ifdefs branch 5 times, most recently from 89c806e to 9616165 Compare August 8, 2024 22:00
@rmackay9
Copy link
Contributor

rmackay9 commented Aug 8, 2024

Thanks for the Topotek fix!

@peterbarker peterbarker force-pushed the pr/rc-channel-ifdefs branch 18 times, most recently from cf70ace to e642e88 Compare August 19, 2024 12:05
@peterbarker peterbarker force-pushed the pr/rc-channel-ifdefs branch 4 times, most recently from ecd4fd5 to 3789dfa Compare September 3, 2024 01:34
… it is

The biggest feature here is the massive whitelist.  Many features can be marked as compiled-in but will be elided by the compiler as it isn't called anywhere.  That's OK, but it does mean we can't check for its  presence or absence based on symbols.
@peterbarker peterbarker merged commit 96fe3da into ArduPilot:master Sep 7, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants