-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ifdefs to remove more code around RC option code #27777
Merged
peterbarker
merged 5 commits into
ArduPilot:master
from
peterbarker:pr/rc-channel-ifdefs
Sep 7, 2024
Merged
Use ifdefs to remove more code around RC option code #27777
peterbarker
merged 5 commits into
ArduPilot:master
from
peterbarker:pr/rc-channel-ifdefs
Sep 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/rc-channel-ifdefs
branch
5 times, most recently
from
August 7, 2024 05:46
7ca2b91
to
8631074
Compare
@peterbarker please test code size on AP_Periph targets too before merge, thanks! |
peterbarker
force-pushed
the
pr/rc-channel-ifdefs
branch
5 times, most recently
from
August 8, 2024 22:00
89c806e
to
9616165
Compare
Thanks for the Topotek fix! |
peterbarker
force-pushed
the
pr/rc-channel-ifdefs
branch
6 times, most recently
from
August 10, 2024 05:16
7e793bd
to
6a882a5
Compare
peterbarker
force-pushed
the
pr/rc-channel-ifdefs
branch
from
August 13, 2024 07:33
6a882a5
to
4d6e764
Compare
peterbarker
force-pushed
the
pr/rc-channel-ifdefs
branch
5 times, most recently
from
August 15, 2024 12:52
558da59
to
cfb5295
Compare
peterbarker
force-pushed
the
pr/rc-channel-ifdefs
branch
18 times, most recently
from
August 19, 2024 12:05
cf70ace
to
e642e88
Compare
peterbarker
force-pushed
the
pr/rc-channel-ifdefs
branch
4 times, most recently
from
September 3, 2024 01:34
ecd4fd5
to
3789dfa
Compare
peterbarker
force-pushed
the
pr/rc-channel-ifdefs
branch
from
September 4, 2024 00:47
3789dfa
to
d12d0c1
Compare
… it is The biggest feature here is the massive whitelist. Many features can be marked as compiled-in but will be elided by the compiler as it isn't called anywhere. That's OK, but it does mean we can't check for its presence or absence based on symbols.
peterbarker
force-pushed
the
pr/rc-channel-ifdefs
branch
from
September 6, 2024 14:29
d12d0c1
to
e5415c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves us closer to being able to remove
default:
clauses.