Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy AP_Notify LED defines #27505

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

peterbarker
Copy link
Contributor

Filtered output shows no binary output changes apart from these:

------------------------  -----  ----------  ------  -----  -----  -----  ----
Board                     blimp  bootloader  copter  heli   plane  rover  sub
PixSurveyA2               -192   *           -192    -192   -184   -192   -192
SITL_arm_linux_gnueabihf  0                  0       0      0      0      0
SITL_x86_64_linux_gnu     0                  0       0      0      0      0
obal                      -560               -4624   -4592  -560   -560   -592
------------------------  -----  ----------  ------  -----  -----  -----  ----

PixSurveyA2 was undeffing the pins for the board leds that it was inheriting, but wasn't undefining the feature, so it was suffering overhead when it didn't need to.

obal is only losing the relevant symbols. The large chunks on some targets seems to be down to an alignment change.

@peterbarker peterbarker merged commit f4f7990 into ArduPilot:master Jul 10, 2024
92 checks passed
@peterbarker peterbarker deleted the pr/notify-defines-fix branch July 10, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants