-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SITL: Add support for AirSim Simulator #11367
Conversation
@OXINARF Thanks! The connection problem is described in detail here - microsoft/AirSim#1965 |
@rajat2004 I've cleaned up the commits using an interactive rebase to follow our commit style |
@tridge I thought that I would squash up the commits after the connection problems were fixed, but thanks for doing that |
@lucasdemarchi Sorry, pressed the resolved button by mistake. If possible, could you open it again ardupilot/libraries/SITL/SIM_JSBSim.cpp Line 391 in 869a369
Even I thought that using little-endian wouldn't be much of a problem, but added that just for making sure. Also, I didn't understand what you meant by fdm_packet should be a pod. What's a pod actually? |
Fixed the connection issues. |
Readme added |
Fixed the gyro initialization by using EKF 10. The bad values are probably due to the collision of the drone with the ground in the beginning. Still figuring out the GPS problem |
On Tue, 21 May 2019, Rajat Singhal wrote:
+ for(int i=0; i<kArduCopterRotorControlCount; ++i) {
Should this be added to the style-guide?
Probably :-)
|
Made some changes, now it doesn't get the random GPS location. But still, there's no sat fix. It's not even detecting the GPS as u-blox which is displayed in the Mavproxy console. Any idea on what is causing this? I haven't squashed this commit so that it would be easier to review these changes and rewind if required |
Also seeing |
Yeah, so the problem is with the timestamp, AirSim sends time from 1970 rather than the simulator start |
Did a bit of hack(similar to the older JSBSim timing), but it's working!! But still, progress! |
Added the sensor conversion changes. |
2fb8dc7
to
770c685
Compare
This PR is no longer compatible with the ArduCopterSoloAPI in Airsim, instead, the corresponding Airsim branch is https://github.com/rajat2004/AirSim/tree/pr-arducopter. The earlier Airsim Solo compatible branch is here - https://github.com/rajat2004/ardupilot/tree/airsim-soloapi Readme has been updated for using the Arducopter vehicle |
f3aa136
to
8a3dd0d
Compare
JSON sensor packet parsing has been added, corresponding changes have been made to the Airsim branch |
1d4f368
to
9468265
Compare
@peterbarker @tridge @khancyr @lucasdemarchi Could you do a fresh review of the PR as it currently stands? All the points raised till now have been addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! This is ready to merge when it passes CI
@tridge Thanks! Just wanted to confirm once |
Supports Lock-Step Scheduling, has JSON sensor packet parsing
@rajat2004 no, we should merge here first I think. done! |
Connector for AirSim based on the ArduCopter Solo API in AirSim: microsoft/AirSim#1387
Described properly with some relevant links in #11324
A WIP, need to figure out some connection issues.
Review Requested @tridge @peterbarker