Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial attempt to add breezy weather support to the main app. #2201

Merged
merged 6 commits into from
Jul 27, 2024

Conversation

dgcampbe
Copy link
Contributor

There are probably some issues. Feel free to help verify that I did this right. 😛

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 21, 2024

I tested it, but it didn't seem to work yet.
It probably needs to be put into all the right folders first?

Breezy weather did detect Arcticons tho, so that's cool!

@Kaiserdragon2
Copy link
Collaborator

I have done some tests and it stops working as soon as the is a suffix like .debug or .light at the end of the app

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 23, 2024

Tested it with a signed apk, no results tho

@Kaiserdragon2
Copy link
Collaborator

Kaiserdragon2 commented Jul 23, 2024 via email

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 23, 2024

I .... I did not run the script -,-

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 23, 2024

It works on the emulator!

(We might need to think dynamic day and night sceming for the widgets and in the app)

image
image

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 24, 2024

How's this?
image

@dgcampbe
Copy link
Contributor Author

Those icons look great! Thanks @Kaiserdragon2 for fixing the position of the metadata tags.

@dgcampbe dgcampbe marked this pull request as ready for review July 25, 2024 22:36
@dgcampbe
Copy link
Contributor Author

Feel free to merge when ready. 😄

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 25, 2024

Want to test if it works dark& night modus, gonna do it tomorrow :)

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 26, 2024

It respects the user preferences now!
image
image

@min7-i
Copy link

min7-i commented Jul 26, 2024

I saw your issue in the Breezy Weather repo.

Just a small hint: If I remember correctly, as long as you only provide weather icons, you don't need to create the xml files for other resources like animated icons, sun & moon, etc.:

  • app/src/main/res/xml/breezy_icon_provider_animator_filter.xml
  • app/src/main/res/xml/breezy_icon_provider_shortcut_filter.xml
  • app/src/main/res/xml/breezy_icon_provider_sun_moon_filter.xml

Then you can also leave that out in the manifest:

        <meta-data
            android:name="org.breezyweather.ANIMATOR_FILTER"
            android:resource="@xml/breezy_icon_provider_animator_filter" />
        <meta-data
            android:name="org.breezyweather.SHORTCUT_FILTER"
            android:resource="@xml/breezy_icon_provider_shortcut_filter" />
        <meta-data
            android:name="org.breezyweather.SUN_MOON_FILTER"
            android:resource="@xml/breezy_icon_provider_sun_moon_filter" />

Breezy Weather will automatically fall back to the defaults if those resources are not provided.

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 26, 2024

Thanks for the suggestions @min7-i !
I'm working on shortcuts, and a sun & moon icon now. But I don't think we'll need the animator (it would look weird with transparent icons, I guess)

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 27, 2024

For some reason, the material you version doesn't show the icons:

image

Shortcuts should work tho
image

@Donnnno Donnnno merged commit eb55c19 into Arcticons-Team:main Jul 27, 2024
1 check passed
@dgcampbe dgcampbe deleted the breezy-weather branch July 30, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants