-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial attempt to add breezy weather support to the main app. #2201
Conversation
I tested it, but it didn't seem to work yet. Breezy weather did detect Arcticons tho, so that's cool! |
I have done some tests and it stops working as soon as the is a suffix like .debug or .light at the end of the app |
Tested it with a signed apk, no results tho |
Did you run the preparerelease.py? Only normal normal had worked and i had
modified the app before and removed all sorts of stuff to test what impacts
the implementation (ui and candybar) where non existent. While implementing
it in the Icon Request app to test if it works was as easy as adding these
lines of code to the manifest file. I will try to test a bit more why it
does not work with the added suffix or if there is something else that
affects this
…On Tue, 23 Jul 2024, 21:06 Donno, ***@***.***> wrote:
Tested it with a signed apk, no results tho
—
Reply to this email directly, view it on GitHub
<#2201 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEEFL4SMDNSQS3E3BEN6QTZN2STBAVCNFSM6AAAAABLGREIPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBWGA3DCMRTGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I .... I did not run the script -,- |
Those icons look great! Thanks @Kaiserdragon2 for fixing the position of the metadata tags. |
Feel free to merge when ready. 😄 |
Want to test if it works dark& night modus, gonna do it tomorrow :) |
I saw your issue in the Breezy Weather repo. Just a small hint: If I remember correctly, as long as you only provide weather icons, you don't need to create the xml files for other resources like animated icons, sun & moon, etc.:
Then you can also leave that out in the manifest:
Breezy Weather will automatically fall back to the defaults if those resources are not provided. |
Thanks for the suggestions @min7-i ! |
There are probably some issues. Feel free to help verify that I did this right. 😛