Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow icon packs to switch colors between the system's light & dark mode #1223

Closed
5 tasks done
Donnnno opened this issue Jul 26, 2024 · 0 comments
Closed
5 tasks done
Labels
Bug Something isn't working Needs review Issue that need to be analyzed (reproduced for a bug, take a decision for an idea, etc)

Comments

@Donnnno
Copy link

Donnnno commented Jul 26, 2024

Steps to reproduce

Hi, we're currently working on implementing an icon pack for breezy into Arcticons. (loving how easy it is to implement)

However, in my testings, I noticed that the icon colors won't change despite it having a color option that should respect the system theme: android:strokeColor="@color/icon_color"

That results in some unfortunate white spaces when the widget and apps are set to light mode (in case the user wants that)

image
image

Would it be possible to make the icons respect the system's (or app's) light & dark mode?

Expected behavior

The icons should change color with the system theme

Actual behavior

Nothing happens

Weather source used

Default

Breezy Weather version

5.2.5_freenet & 5.2.6_freenet

Android version

Android 13

Device

Pixel 7a emulator

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open OR closed issue.
  • I checked that my issue is not covered in the Frequently Asked Questions document.
  • I have updated the app to version 5.2.6 or later and I can reproduce the issue in this version.
  • I wrote my request in English, and any screenshot I attached are also in English (language can be changed from Settings > Appearance), unless my issue only happens with a specific language. I can write in my native language under the English text, if necessary.
  • I understand that this app is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY, so I may not get a positive reply to my request, if any at all.
@Donnnno Donnnno added Bug Something isn't working Needs review Issue that need to be analyzed (reproduced for a bug, take a decision for an idea, etc) labels Jul 26, 2024
@breezy-weather breezy-weather locked and limited conversation to collaborators Jul 26, 2024
@papjul papjul converted this issue into discussion #1224 Jul 26, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Bug Something isn't working Needs review Issue that need to be analyzed (reproduced for a bug, take a decision for an idea, etc)
Projects
None yet
Development

No branches or pull requests

1 participant