-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .metainfo.xml files #1341
base: master
Are you sure you want to change the base?
Conversation
Previously, appimagetool had expected a .appdata.xml file, although that format had been deprecated and .metainfo.xml should be used for new projects. This has been fixed. Support for .metainfo.xml files has been added. appimagetool now accepts both .metainfo.xml and .appdata.xml files. A warning has also been added when using a .appdata.xml file that the file extension should be changed to .metainfo.xml. Additionally, the link to the generator hadn't worked anymore. It has been replaced with a working link to an AppStream generator.
Related:
Maybe these can be merged and resolved as well? I feel like they have been forgotten. I also plan to update the documentation (not just about this specifically, but in general, there are some things that I think can be improved to make it easier to understand for people who have never used AppImages before). |
Hm, i just now searched for other related issues and PRs and realised that #1224 essentially does the same. |
} | ||
|
||
if (appstream_found) { | ||
fprintf (stderr, "AppStream upstream metadata found in usr/share/metainfo/%s\n", *appstream_filename); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stderr
is not needed here?
Please use the search function. This has been discussed before. We are not fond of supporting two of these files. We need to find a way to specify one frozen AppStream spec version, and stay with it. We don't want to work with moving targets. |
I'm sorry, I originally only found AppImage/appimage.github.io#3067. Because it was merged, I assumed that you want to support |
Well, sooner or later we will probably have to do the switch, if we stay with AppStream at all. We still are struggling with or maybe retire it in favor of
|
Previously,
appimagetool
has expected a.appdata.xml
file, although that format has been deprecated and.metainfo.xml
should be used for new projects. This Pull Request fixes this issue. It adds support for.metainfo.xml
files. With this PR,appimagetool
will accept both.metainfo.xml
and.appdata.xml
files.This PR also adds a warning when using a
.appdata.xml
file that the file extension should be changed to.metainfo.xml
.Additionally, the link to the generator hasn't worked anymore. This PR replaces it with a working link to an AppStream generator.