Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appdir-lint.sh need to detect *.metainfo.xml if *appdata.xml not availiable #541

Open
shenlebantongying opened this issue Jun 23, 2023 · 5 comments

Comments

@shenlebantongying
Copy link

pkg2appimage/appdir-lint.sh

Lines 124 to 129 in c302f81

# Find the relevant appdata.xml file;
# according to ximion, usr/share/appdata is a legacy path replaced by usr/share/metainfo
APPDATA=$(ls "${APPDIR}"/usr/share/metainfo/*appdata.xml 2>/dev/null | head -n 1) # TODO: Handle more than one better
if [ -z "$APPDATA" ] ; then
APPDATA=$(ls "${APPDIR}"/usr/share/appdata/*appdata.xml 2>/dev/null | head -n 1) # TODO: Handle more than one better
fi

@shenlebantongying
Copy link
Author

Appstream's fault.

@Korne127
Copy link
Contributor

What do you mean with Appstream's fault / why did you close this?

@shenlebantongying
Copy link
Author

What do you mean with Appstream's fault

Changing the widely used name/path and requiring the entire ecosystem to change is generally a insane and horrific thing to do.

why did you close this?

I forget why, maybe misclick.

@Korne127
Copy link
Contributor

Yeah, I agree :/

@probonopd
Copy link
Member

These files are entirely optional as per the AppImageSpec, aren't they?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants