Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Review Feedback #1520

Merged
merged 7 commits into from
Aug 28, 2023
Merged

API Review Feedback #1520

merged 7 commits into from
Aug 28, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 28, 2023

Details on the issue fix or feature implementation

  • Improved XML docs for arguments.
  • Drop OnHedgingArguments.HasOutcome property
  • Introduce FallbackActionArguments (instead of using FallbackPredicateArguments in FallbackAction delegate)
  • Rename RetryDelayArguments to RetryDelayGeneratorArguments
  • Rename HedgingDelayArguments to HedgingDelayGeneratorArguments
  • Allow registering multiple listeners in TelemetryOptions

Contributes to #1507

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 28, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1520 (d478352) into main (60288c8) will increase coverage by 0.01%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head d478352 differs from pull request most recent head edbd646. Consider uploading reports for the commit edbd646 to get more accurate results

@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
+ Coverage   84.10%   84.11%   +0.01%     
==========================================
  Files         277      278       +1     
  Lines        6581     6586       +5     
  Branches     1025     1026       +1     
==========================================
+ Hits         5535     5540       +5     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
macos 84.11% <100.00%> (+0.01%) ⬆️
windows 84.11% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...CircuitBreaker/CircuitBreakerPredicateArguments.cs 100.00% <ø> (ø)
...ly.Core/CircuitBreaker/OnCircuitClosedArguments.cs 100.00% <ø> (ø)
...ly.Core/CircuitBreaker/OnCircuitOpenedArguments.cs 100.00% <ø> (ø)
.../Polly.Core/Fallback/FallbackPredicateArguments.cs 100.00% <ø> (ø)
src/Polly.Core/Fallback/OnFallbackArguments.cs 100.00% <ø> (ø)
...lly.Core/Hedging/HedgingDelayGeneratorArguments.cs 100.00% <ø> (ø)
...rc/Polly.Core/Hedging/HedgingPredicateArguments.cs 100.00% <ø> (ø)
src/Polly.Core/Retry/OnRetryArguments.cs 100.00% <ø> (ø)
...c/Polly.Core/Retry/RetryDelayGeneratorArguments.cs 100.00% <ø> (ø)
src/Polly.Core/Retry/RetryPredicateArguments.cs 100.00% <ø> (ø)
... and 12 more

@martintmk martintmk enabled auto-merge (squash) August 28, 2023 09:16
@martintmk martintmk merged commit f9b1afc into main Aug 28, 2023
@martintmk martintmk deleted the mtomka/api-feedback branch August 28, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants