Skip to content

Commit

Permalink
PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
martintmk committed Aug 28, 2023
1 parent d478352 commit edbd646
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public CircuitBreakerPredicateArguments(ResilienceContext context, Outcome<TResu
}

/// <summary>
/// Gets the outcome of user-callback.
/// Gets the outcome of the user-specified callback.
/// </summary>
public Outcome<TResult> Outcome { get; }

Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/Fallback/FallbackPredicateArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public FallbackPredicateArguments(ResilienceContext context, Outcome<TResult> ou
}

/// <summary>
/// Gets the outcome of user-callback.
/// Gets the outcome of the user-specified callback.
/// </summary>
public Outcome<TResult> Outcome { get; }

Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/Hedging/HedgingPredicateArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public HedgingPredicateArguments(ResilienceContext context, Outcome<TResult> out
}

/// <summary>
/// Gets the outcome of user-callback.
/// Gets the outcome of the user-specified callback.
/// </summary>
public Outcome<TResult> Outcome { get; }

Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/Retry/RetryPredicateArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public RetryPredicateArguments(ResilienceContext context, Outcome<TResult> outco
}

/// <summary>
/// Gets the outcome of user-callback.
/// Gets the outcome of the user-specified callback.
/// </summary>
public Outcome<TResult> Outcome { get; }

Expand Down
1 change: 1 addition & 0 deletions src/Polly.Extensions/Telemetry/TelemetryListenerImpl.cs
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public TelemetryListenerImpl(TelemetryOptions options)

public override void Write<TResult, TArgs>(in TelemetryEventArguments<TResult, TArgs> args)
{
// stryker disable once equality : no means to test this
if (_listeners.Count > 0)
{
foreach (var listener in _listeners)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,9 @@ public async Task AddHedging_IntegrationTest()
},
OnHedging = args =>
{
if (args.Outcome is not null)
if (args.Outcome is { } outcome)
{
results.Enqueue(args.Outcome!.Value.Result!.ToString()!);
results.Enqueue(outcome.Result!.ToString()!);
}
else
{
Expand Down

0 comments on commit edbd646

Please sign in to comment.