Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SonarAnalyzer.CSharp from 8.51.0.59060 to 8.56.0.67649 #1149

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 20, 2023

Bumps SonarAnalyzer.CSharp from 8.51.0.59060 to 8.56.0.67649.

Release notes

Sourced from SonarAnalyzer.CSharp's releases.

8.56

Release 8.56 is here and it brings a whole lot of improvements. We implemented S3900 and S3655 for VB.NET and at the same time, we also got improvements to the C# versions of S3900, S3655, S2222, and S2259. Special kudos to @​Corniel who contributed new rule S5856 and several other enhancements.

New Rules

  • 6797 - [VB.NET] New Rule S3900 for VB.NET: Arguments of public methods should be validated against Nothing
  • 6795 - [VB.NET] New Rule S3655 for VB.NET: Empty nullable value should not be accessed
  • 6691 - [C#, VB.NET] New Rule S5856: Regex literals should be valid by @​Corniel

Improvements (S3900, S3655, S2222, and S2259)

  • 6794 - [C#] Improve S3655: Support C# 9 and C# 10 syntax
  • 6793 - [C#] Improve S3900: Support C# 9 and C# 10 syntax
  • 6997 - [C#] Fix S3900: FN and FP
  • 7060 - [C#] Fix S3900 FP: Don't raise if parameter is captured
  • 2775 - [C#] Fix S3900 FP: is is not considered as null-check
  • 2670 - [C#] Fix S3900 FP: with string.IsNullOrEmpty
  • 7004 - [C#] Fix S3900: Change parameter dereference check to top-down
  • 6682 - [C#] Fix S3655 FP: HasValue checked with Pattern matching
  • 4250 - [C#] Fix S2259 FP: Lifted operator results in null value in value type comparison
  • 6994 - [C#, VB.NET] Fix S2222: Branch on createdNew parameter on Mutex constructor
  • 6840 - [C#, VB.NET] Fix S2259 FP/FN: Do not raise on Nullable members
  • 6241 - [C#, VB.NET] Fix S2259 FP: is null check on generic type
  • 6930 - [C#, VB.NET] Fix S2259 FN: Auto-Properties don't learn ObjectConstraint
  • 6898 - [C#, VB.NET] Fix S2259 FN: Raise on fields and events
  • 7048 - [VB.NET] Fix S2259 FP: ValidatedNotNullAttribute in extension method
  • 7047 - [VB.NET] Fix S3900 FP: Recognize VB extensions
  • 6991 - [VB.NET] Fix S3655 FN: VB implicit conversions

Other improvements

  • 6899 - Update RSPEC
  • 6910 - Fix S2094 FP: Allow to have empty classes, used as generic parameter
  • 6878 - [C#] Fix S1168 FP: Does not respect nullable annotations by @​Corniel
  • 6890 - [C#, VB.NET] Fix S1123 FN: The explanation should not be null or whitespace by @​Corniel

@​corniel contributions

  • 6691 - [C#, VB.NET] New Rule S5856: Regex literals should be valid
  • 6890 - [C#, VB.NET] Fix S1123 FN: The explanation should not be null or whitespace
  • 6825 - [C#] Expand the ShimLayer with ITypeSymbol.NullableAnnotation
  • 6878 - [C#] Fix S1168 FP: Does not respect nullable annotations

8.55

This version contains the prerequisite to support sonar.exclusions, sonar.inclusions, sonar.global.exclusions, sonar.test.exclusions, sonar.test.inclusions and sonar.global.test.exclusions parameters when the analysis is run inside SonarLint for Visual Studio. Stay tuned, the second and final part of the feature will be implemented soon by the SonarLint team.

In the meantime, if you are wondering what these parameters are, you can find more information about them in our documentation.

  • 6877 - Support exclusion and inclusion parameters when run by SonarLint

New Rules

  • 6885 - [C#, VB.NET] ExcludeFromCodeCoverage attributes should include a justification

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 8.51.0.59060 to 8.56.0.67649.
- [Release notes](https://github.com/SonarSource/sonar-dotnet/releases)
- [Commits](SonarSource/sonar-dotnet@8.51.0.59060...8.56.0.67649)

---
updated-dependencies:
- dependency-name: SonarAnalyzer.CSharp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Apr 20, 2023
@martintmk martintmk enabled auto-merge (squash) April 21, 2023 07:58
@codecov-commenter
Copy link

Codecov Report

Merging #1149 (cc61a4a) into main (cec36cb) will increase coverage by 0.65%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
+ Coverage   79.16%   79.82%   +0.65%     
==========================================
  Files         213      229      +16     
  Lines        5084     5199     +115     
  Branches      882      888       +6     
==========================================
+ Hits         4025     4150     +125     
+ Misses        854      844      -10     
  Partials      205      205              
Flag Coverage Δ
linux 79.82% <100.00%> (+0.65%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/AdvancedCircuitBreakerStrategyOptions.TResult.cs 100.00% <100.00%> (ø)
...itBreaker/AdvancedCircuitBreakerStrategyOptions.cs 100.00% <100.00%> (ø)
...eaker/BaseCircuitBreakerStrategyOptions.TResult.cs 100.00% <100.00%> (ø)
...ircuitBreaker/BaseCircuitBreakerStrategyOptions.cs 100.00% <100.00%> (ø)
...e/CircuitBreaker/BrokenCircuitException.TResult.cs 100.00% <100.00%> (ø)
...olly.Core/CircuitBreaker/BrokenCircuitException.cs 100.00% <100.00%> (ø)
...lly.Core/CircuitBreaker/CircuitBreakerConstants.cs 100.00% <100.00%> (ø)
...Core/CircuitBreaker/CircuitBreakerManualControl.cs 100.00% <100.00%> (ø)
...CircuitBreaker/CircuitBreakerPredicateArguments.cs 100.00% <100.00%> (ø)
...CircuitBreaker/CircuitBreakerResilienceStrategy.cs 100.00% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@martintmk martintmk merged commit febd641 into main Apr 21, 2023
@martintmk martintmk deleted the dependabot/nuget/SonarAnalyzer.CSharp-8.56.0.67649 branch April 21, 2023 08:32
@martincostello
Copy link
Member

Thanks for fixing - I'd been meaning to sort it out in #1081 for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants