Fix S3900 FP: Don't raise if parameter is captured (#7065)

SonarSource · Apr 14, 2023 · 3420f6c · 3420f6c
1 parent 5904844
commit 3420f6c
Show file tree

Hide file tree

Showing 29 changed files with 65 additions and 1,247 deletions.
diff --git a/analyzers/its/expected/Automapper/AutoMapper--net461-S3900.json b/analyzers/its/expected/Automapper/AutoMapper--net461-S3900.json
@@ -405,19 +405,6 @@
 },
 {
 "id":  "S3900",
-"message":  "Refactor this method to add validation of parameter 'memberNames' before using it.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\Configuration\MappingExpression.cs",
-"region":  {
-"startLine":  37,
-"startColumn":  39,
-"endLine":  37,
-"endColumn":  50
-}
-}
-},
-{
-"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'memberOptions' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\Configuration\MappingExpression.cs",
@@ -2186,32 +2173,6 @@
 },
 {
 "id":  "S3900",
-"message":  "Refactor this method to add validation of parameter 'sourceMemberInfo' before using it.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\QueryableExtensions\QueryMapperVisitor.cs",
-"region":  {
-"startLine":  224,
-"startColumn":  51,
-"endLine":  224,
-"endColumn":  67
-}
-}
-},
-{
-"id":  "S3900",
-"message":  "Refactor this method to add validation of parameter 'sourceMemberInfo' before using it.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\QueryableExtensions\QueryMapperVisitor.cs",
-"region":  {
-"startLine":  231,
-"startColumn":  63,
-"endLine":  231,
-"endColumn":  79
-}
-}
-},
-{
-"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'config' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\QueryableExtensions\QueryMapperVisitor.cs",

diff --git a/analyzers/its/expected/Automapper/AutoMapper--netstandard2.0-S3900.json b/analyzers/its/expected/Automapper/AutoMapper--netstandard2.0-S3900.json
@@ -405,19 +405,6 @@
 },
 {
 "id":  "S3900",
-"message":  "Refactor this method to add validation of parameter 'memberNames' before using it.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\Configuration\MappingExpression.cs",
-"region":  {
-"startLine":  37,
-"startColumn":  39,
-"endLine":  37,
-"endColumn":  50
-}
-}
-},
-{
-"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'memberOptions' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\Configuration\MappingExpression.cs",
@@ -2186,32 +2173,6 @@
 },
 {
 "id":  "S3900",
-"message":  "Refactor this method to add validation of parameter 'sourceMemberInfo' before using it.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\QueryableExtensions\QueryMapperVisitor.cs",
-"region":  {
-"startLine":  224,
-"startColumn":  51,
-"endLine":  224,
-"endColumn":  67
-}
-}
-},
-{
-"id":  "S3900",
-"message":  "Refactor this method to add validation of parameter 'sourceMemberInfo' before using it.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\QueryableExtensions\QueryMapperVisitor.cs",
-"region":  {
-"startLine":  231,
-"startColumn":  63,
-"endLine":  231,
-"endColumn":  79
-}
-}
-},
-{
-"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'config' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\QueryableExtensions\QueryMapperVisitor.cs",