-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow boolean array [true, false]
to be a valid argument for BooleanValidator
#848
Allow boolean array [true, false]
to be a valid argument for BooleanValidator
#848
Conversation
f50cd4d
to
0cf4c11
Compare
[true, false]
e528ec1
to
f5317ac
Compare
f5317ac
to
f93d6cb
Compare
[true, false]
to be a valid argument for BooleanValidator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'm slightly afraid this could introduce a breaking change... ?
We can always put it behing and setting for example Apipie.configure do |config|
config.validator.boolean.handle_boolean_array = false
end My question is why use I can't think any compelling reason to do so and I'm leaning on closing this PR 😅 (we can use the tests refactoring in another PR) |
I don't know, we can keep it open for a while and wait if others wants to chime in their opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want to solve the conflict after the refactor, I will merge this as well.
Since `BooleanValidator`can now be created from `[true, false]` we no longer need to handle this case in the generator.
f93d6cb
to
e365a53
Compare
Thanks, I wasn't exactly sure about the spec removal... |
How
[true, false]
as argument.[true, false]
handling from Swagger generatorIt would probably be easier to review per commit