Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add two tests when using an array of value for boolean #786

Closed
wants to merge 6 commits into from
Closed

add two tests when using an array of value for boolean #786

wants to merge 6 commits into from

Conversation

mathieujobin
Copy link
Collaborator

No description provided.

@mathieujobin
Copy link
Collaborator Author

could someone provide some help fixing these new tests?

@PanosCodes
Copy link
Contributor

They were failing because the BooleanValidator did not accept [true, false] as argument.

For example

Apipie::Validator::BooleanValidator.build(param_description, [true, false], nil, nil)

would return nil

This commit b484c28 fixes that. I remember us talking about it here

wdyt about #848 ?

@mathieujobin mathieujobin deleted the test-boolean-in-array branch April 11, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieujobin @PanosCodes