upgrade to webpack 5 #208
upgrade to webpack 5 #208
Conversation
| @@ -288,17 +290,6 @@ function plugins() { | |||
| plugins.push(new ForkTsCheckerWebpackPlugin(forkTsCheckerWebpackOptions)); | |||
| } | |||
|
|
|||
| if (ENABLE_CACHING) { | |||
There was a problem hiding this comment.
not needed anymore as webpack5 has caching built in
| @@ -1,10 +1,6 @@ | |||
| import { hi } from "@my-org/some-lib/index"; | |||
| import { merhaba } from "./tsx/import"; | |||
|
|
|||
| export const typescript4Inject = <A extends []>( | |||
There was a problem hiding this comment.
this caused an eslint error and I did not understand what it did as the function is never called
disable cache
|
@jayair could you review this please :) |
|
Thanks @thomaschaaf. I'll take a look this weekend! |
|
@thomaschaaf This is awesome. Thank you. Are there any breaking changes in this? Do you think this needs a canary release to test or is it stable enough that we could release it live? |
|
@thomaschaaf I think you should use npmv7 to work with the |
|
@jayair no known breaking changes. I have alos just upgraded serverless-webpack - which should improve deployment speed. If you want I can test the canary release. @joewestcott I'm not using node 15 yet with which npm v7 will be published. I personally think it does not make sense to use npm v7 before node 16 is released. It will result in the |
|
@jayair can we get this packaged? |
|
@thomaschaaf I just need a little bit of time to go through and test all of this. It's a slightly big change. I'll get to it next weekend. |
|
@thomaschaaf So I had a look at all your PRs. Thanks for all the hard work! I think it make sense that we put them all together cut a |
|
Yey! Yes it all belongs together. I think making a major version for webpack seems like a good decision. Maybe also drop old node versions. |
|
Yeah agreed. If you can merge it into one PR then I'll cut a beta release. Thank you! |
|
@jayair ready to make a new Version 🙌 |
|
Thank you! Pushed a new canary release https://github.com/AnomalyInnovations/serverless-bundle/releases/tag/v5.0.0-beta.0 Starting a new thread to help test it and collect feedback. |
This fix also includes some other PRs work.
Breaking:
node10 was removed and instead of webpack4 we are now using webpack 5.
fixes #195