Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warmup workaround #202

Closed

Conversation

juanjoDiaz
Copy link

This PR removes the workaround to the issues with the wamup plugin.

That workaround only worked with versions 4.X of warmup since version 5.X change the folder from _warmup to .warmup.
Also, I modified the warmup plugin use of lifecycle hooks so it will not conflict with this or the webpack plugin as long as it's declared after it.

@jayair jayair added the enhancement New feature or request label Feb 27, 2021
@jayair
Copy link
Member

jayair commented Feb 27, 2021

Thanks @juanjoDiaz! Appreciate the PR!

Would keeping this fix around make sense if somebody is still using 4.x? And, does the fix break for somebody using 5.x?

@juanjoDiaz
Copy link
Author

This workaround still works for v4.x (as long as they don't change the default setting that created the _warmup folder).
This doesn't break anything for the rest of the users as long as they don't have a folder named _warmup.

This workaround doesn't work in v5 because v5 doesn't use _warmup, it uses custom names that are given by the user like .warmup/<my_warmer>/index and there can be multiple entries.

And it's not even needed after v5.2.1 since I added a workaround on my end.

To be honest, people should update to v5. The upgrade is trivial and there is nothing in v4 that's not in v5.

@thomaschaaf
Copy link
Contributor

implemented in #208

@jayair jayair closed this Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants