Use C++ variadic templates for MakePath #398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should improve performance and reduce errors by moving more of the initialization to compile time.
AngusJohnson
reviewed
Feb 6, 2023
| { | ||
| static_assert(N % 2 == 0, "MakePath requires an even number of arguments"); | ||
| Path64 result(N / 2); | ||
| for (size_t i = 0; i < N; ++i) |
There was a problem hiding this comment.
Path64 result;
result.reserve(N / 2);
#ifdef USINGZ
for (size_t i = 0; i < N; ++i)
result.emplace_back(Point64{ list[i], list[++i], 0 });
#else
for (size_t i = 0; i < N; ++i)
result.emplace_back(Point64{ list[i], list[++i] });
#endif
AngusJohnson
added a commit
that referenced
this pull request
Feb 6, 2023
Fixed InflatePaths to return unchanged paths when delta == 0 (#389) Minor tweak to detecting "touching" solution polygons Fixed minor bug in ClipperOffset (#392,#393) Tidied up error handling in C++ Added error_code param to ScalePath function (C++) Tweaks to C# CI testing (#388) Major rewrite of RectClip function (Delphi only so far) (#383)
|
Hi Justin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds variadic template functions for MakePath and MakePathD. In addition to being more in keeping with modern C++ style, they allow the compiler to validate the arguments and optimize away most of the runtime initialization code.
I converted over most of the tests, but left one to retain coverage of the existing string-based MakePath and MakePathD.