Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the 'quick switch between documents' option #597

Closed
agrogers opened this issue Mar 27, 2020 · 12 comments · Fixed by #954
Closed

Bring back the 'quick switch between documents' option #597

agrogers opened this issue Mar 27, 2020 · 12 comments · Fixed by #954

Comments

@agrogers
Copy link
Contributor

agrogers commented Mar 27, 2020

First, andBible is fantastic. Thank you.

Second, I have missed the ability to simply click the Commentary (or Bible) buttons at the top to move to the next Commentary in the list. Now when I click I need to choose what I want from the drop down list.

The old method was great because I could very quickly peruse all the commentaries.

The new method has made that process much slower (click, scan list, identify the next item, click). The scan and identify part for me makes the process at least three+ times slower.

The attached image shows why. I have chosen a commentary that has no entry. In the old version to move to the next commentary I just push the button again. But now I have to work out which commentary is next in the list. But the displayed name in the header and the name in the list is not the same. So I need to remember what the short name is for the current commentary, find where it would be in the list (not so easy because it's been removed from the list) then select the next entry after this. I find I make mistakes in this process by selecting a previous commentary or I skip a commentary or I come to the end of the list I need to remember to go back to the top. All this takes a lot more mental energy than the old method. And often the end result is 'Not found in document' :-) It is that mental energy and clicking energy that bothers me more than the time.

I used to do it for Bible verses as well to quickly see if any showed notable differences. I don't do that anymore because the effort doesn't justify the reward. I will probably use the Parallel Passages option if I really need it. But that doesn't give quick access to the context which I found helpful.

I appreciate though that the new method is more intuitive for new users. However the previous long press method to get the list if you wanted it was perfect I thought.

Proposal:
Is it possible to

  1. Bring back the long click on the Commentary (and other) buttons which cycles through the commentaries like the old way did.
    Or
  2. Add an option in settings to configure how the changing takes place - either the new method or the old method.

Thanks!
Screenshot_2020-03-28-09-08-13-301_net bible android activity

@agrogers agrogers changed the title Bring back the quick switch between documents option Bring back the 'quick switch between documents' option Mar 27, 2020
@tuomas2 tuomas2 added this to the v3.3 milestone Mar 29, 2020
@timbze
Copy link
Contributor

timbze commented Apr 1, 2020

@agrogers Somewhat of a work-around would be to add multiple windows with different versions as unpinned, and when you select another button from the bottom the window will switch to that version.

I see Tuomas added to 3.3 milestone though so it looks like he has plans to do something with this.

Blessings

@tuomas2
Copy link
Contributor

tuomas2 commented Apr 1, 2020

I added milestone so that this will be considered/decided before 3.3.

@agrogers
Copy link
Contributor Author

agrogers commented Apr 1, 2020 via email

@tuomas2
Copy link
Contributor

tuomas2 commented Apr 10, 2020

Interesting suggestion. I might experiment with that. I don't think it will solve my initial complaint but it is a good idea - there are a few commentaries I always go to. Re another possible implementation of the quick switch, maybe a swipe down action on the Commentary button could change to the next commentary in the list.

Yep suggested workflow is to work with multiple non-pinned windows to do such quick switching. For general use, I believe that bible & commentary buttons are now much more usable than before.

Closing this.

@tuomas2 tuomas2 closed this as completed Apr 10, 2020
@agrogers
Copy link
Contributor Author

agrogers commented Apr 11, 2020 via email

@agrogers
Copy link
Contributor Author

agrogers commented May 16, 2020 via email

@agrogers
Copy link
Contributor Author

agrogers commented May 16, 2020 via email

@tuomas2 tuomas2 removed this from the v3.3 milestone May 18, 2020
@tuomas2 tuomas2 reopened this May 18, 2020
@tuomas2
Copy link
Contributor

tuomas2 commented May 18, 2020

Back to this one again :-) Trying to understand who Mat 12:36 "I tell you, on the day of judgment people will give account for every careless word they speak," applies toband so really want to look at what every Commentary I have says about it. It seemed that a possible location for an option is on the window button that fades. A 'Next document' option would do what I want - quickly get to whatever the next document is in the list. It would work for commentaries and bibles. That pop up menu is getting long though. I think you can remove the top Create New window button now you have just added the create window button to the bottom row of buttons (I like it there - good job). So there is space

You can also create copies of window by "new window" from window popup menu, which you can access also by long-clicking window button bar (on the bottom) items. So suggested workflow would be like this:

  1. Have pinned bible view, and unpinned commentary view
  2. Create new window from commentary view, many times
  3. Choose desired commentary for each
  4. Switch between (non-pinned) commentaries by clicking window button bar items.

@timbze
Copy link
Contributor

timbze commented Jul 19, 2020

Maybe it would be an option to implement a "double-tap" to quick-switch, if that would be possible.
Edit: From some checking on how the menu operates etc, I don't think that double tap would be a feasible solution at all

@dwaynedauzat
Copy link

First, andBible is fantastic. Thank you.

Second, I have missed the ability to simply click the Commentary (or Bible) buttons at the top to move to the next Commentary in the list. Now when I click I need to choose what I want from the drop down list.

The old method was great because I could very quickly peruse all the commentaries.

The new method has made that process much slower (click, scan list, identify the next item, click). The scan and identify part for me makes the process at least three+ times slower.

The attached image shows why. I have chosen a commentary that has no entry. In the old version to move to the next commentary I just push the button again. But now I have to work out which commentary is next in the list. But the displayed name in the header and the name in the list is not the same. So I need to remember what the short name is for the current commentary, find where it would be in the list (not so easy because it's been removed from the list) then select the next entry after this. I find I make mistakes in this process by selecting a previous commentary or I skip a commentary or I come to the end of the list I need to remember to go back to the top. All this takes a lot more mental energy than the old method. And often the end result is 'Not found in document' :-) It is that mental energy and clicking energy that bothers me more than the time.

I used to do it for Bible verses as well to quickly see if any showed notable differences. I don't do that anymore because the effort doesn't justify the reward. I will probably use the Parallel Passages option if I really need it. But that doesn't give quick access to the context which I found helpful.

I appreciate though that the new method is more intuitive for new users. However the previous long press method to get the list if you wanted it was perfect I thought.

Proposal:
Is it possible to

1. Bring back the long click on the Commentary (and other) buttons which cycles through the commentaries like the old way did.
   Or

2. Add an option in settings to configure how the changing takes place - either the new method or the old method.

Thanks!

Hello. I just want to say that everything agrogers has said in his first post above is exactly how I feel. I love andBible and have used it for years. I joined GitHub solely to respond to this issue.

I'm not sure why the feature has changed or was taken away but it was perfect beforehand. I propose to simply bring back the previous functionality of the buttons so that they work as follows:

  1. Single tap to quickly switch to the next document and long press to display the list.
    or
  2. Include an option in the settings to select how the buttons work (single tap to quickly switch documents or single tap to display the list).

This is basically what agrogers has already suggested. I just wanted to reiterate it because it has made a big change in the way I use andBible, in a negative way.

I have tried the new pinned windows feature. It is a neat functionality but, the way that I use andBible, it is not something that I will be using.

Thank you for a wonderful app and for taking the time to hear my issue.

@timbze
Copy link
Contributor

timbze commented Aug 26, 2020

In my opinion the current behavior is good for default.

I think it may be a good idea to add "swipe down" on button to do "quick switching" (@agrogers idea above).

And to take it one step further, there could be a setting to swap button press and swipe down. E.g. to press for quick switch, and swipe down for document list menu, or vice versa which can be configured with a setting.

@timbze timbze added this to the v3.4 milestone Jan 4, 2021
@tuomas2 tuomas2 removed their assignment Mar 4, 2021
@tuomas2 tuomas2 modified the milestones: v3.4, v3.5 Mar 4, 2021
@timbze
Copy link
Contributor

timbze commented Mar 26, 2021

Developer info:
Idea to change came partially from #578
First change away from switching documents with single click: fb5d2ef - March 10, 2020
Another change: 225a550 - Apr 2, 2020
Further change for long press: 1e8f190 - Apr 10, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants