Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Babylon again #15

Closed
emackey opened this issue Jun 2, 2017 · 3 comments
Closed

Update Babylon again #15

emackey opened this issue Jun 2, 2017 · 3 comments
Assignees
@HowardWolosky
Labels
update

Comments

@emackey
Copy link
Member

emackey commented Jun 2, 2017

BabylonJS needs another update, to pick up BabylonJS/Babylon.js#2222.

As a result of this update, the "NormalTangentTest" model from the 2.0 sample models should have better lighting/reflections on it.

@HowardWolosky can I trouble you with this request? Also would you like push access to this repo?
@HowardWolosky
Copy link
Contributor

Sure -- I can do the update once that PR hits master. And sure, I'll take push access as well, thanks for the offer!

HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this issue Jun 2, 2017
@HowardWolosky
Update the Cesium and Babylon engines / Make Babylon work on unsaved …
5ef5e60 
…changes

* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).
* Babylon (like Cesium) now defaults to previewing the content in the tab as opposed to the content saved in the file, the same way it's done in this [Babylon Plaground Example](https://www.babylonjs-playground.com/#1AbIIF#7).

Resolves Issue AnalyticalGraphicsInc#15

> **Work in Progress**
> - This doesn't have a Babylon with pull 2222 since that hasn't been taken to master
> - Active preview for Babylon is not currently working for some reason.  More investgiation needs to happen.
@emackey
Copy link
Member Author

emackey commented Jun 5, 2017

Looks like push access was granted this morning, great! No rush on the update here.

@emackey emackey added the update label Jun 5, 2017
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this issue Jun 5, 2017
@HowardWolosky
Update the Cesium and Babylon engines / Make Babylon work on unsaved …
e627746 
…changes

* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).
* Babylon (like Cesium) now defaults to previewing the content in the tab as opposed to the content saved in the file, the same way it's done in this [Babylon Plaground Example](https://www.babylonjs-playground.com/#1AbIIF#7).

Resolves Issue AnalyticalGraphicsInc#15

> **Work in Progress**
> - Active preview for Babylon is not currently working for some reason.  More investgiation needs to happen.
@HowardWolosky HowardWolosky self-assigned this Jun 5, 2017
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this issue Jun 5, 2017
@HowardWolosky
Update the Cesium and Babylon engines
199b646 
* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).

Resolves Issue AnalyticalGraphicsInc#15
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this issue Jun 5, 2017
@HowardWolosky
Update the Cesium and Babylon engines
ec3875b 
* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).

Resolves Issue AnalyticalGraphicsInc#15
@HowardWolosky HowardWolosky mentioned this issue Jun 5, 2017
Merged
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this issue Jun 5, 2017
@HowardWolosky
Update the Cesium and Babylon engines
ed5b27e 
* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).

Resolves Issue AnalyticalGraphicsInc#15
@emackey
Copy link
Member Author

emackey commented Jun 6, 2017

Thanks @HowardWolosky!

@emackey emackey closed this as completed Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HowardWolosky HowardWolosky

Labels
update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emackey @HowardWolosky