-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1 MVP #63
Merged
Merged
v1 MVP #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* clean up deps * add ESLint * add WTR for testing * github actions and everything working * update README * minor README fixes:
* refine contributing docs and README * refine contributing docs and README
* set up the project * changes as per requested * clean up dependencies and roll back home page changes * fix linting * delete empty file Co-authored-by: Owen Buckley <[email protected]>
* initial prototyping with Tailwind * downgrade tailwind v2 for Storybook compat * enable tailwind JiT mode for development * full storybook based documentation and font families
* additional configuration and styletweaks for Storybook * delete all styles and favor Tailwind first
* initial footer implementation * center and finish styling footer * clean up extra footer content from home page * add test cases * fix variable names in spec
* add cooper black font to project * add swap font fallback to css * trust the linter, not matter how random the rule * change file name for git to recognize change
* initial version of cast and crew section * basic styling and theming of the header * add test cases
* add basic header component based on spec * pr feedback: update logo image file, add test to header for image
* init commit of WIP upcoming events component * handle multiple months, multiple events, and out order sorting * support no upcoming events * keep events in the current month in the list * spruce up event alignment and justification * add unit tests * updated styling * leave note about JSON serialization issue
#46) * sync upcoming events component with API and hack work around for apostrophes in JSON * track hack work around
* add favicons and associated files * add root level favicon * remove extranious favicon material * pr feedback: in the correct spots
* add skeleton for navigation * pr feednabck: lists && apply rebased styles * betetr window check * pr feedback: fix path check * clean up nav test code * clean up nav test code * clean up nav test code * clean up nav test code Co-authored-by: Owen Buckley <[email protected]>
* add spotify playlist iframe to component * pr feedback: add test, rename for clarity
* feat: ✨ Youtube Playlist Component Created a component to accommodate listing the youtube playlist. for now just the images and their titles. * initial version of cast and crew section * basic styling and theming of the header * add test cases * refactor: 🎨 updated component to display both youtube in iframe and img playlist Saved the Youtube data API response in two separate json files. Added stories for quick display * delete cast and crew component * update YouTube player implementation to an iframe * branch cleanup * add test case * restore cast and crew files Co-authored-by: Owen Buckley <[email protected]>
* initial working integration of API events * upgrade latest greenwood v0.26.1 * initial home page composition * integrate YouTube playlist component * upgrade Greenwood v0.26.2 * initial home page composition and sectioning * greeting message and minor tweaks * apply first pass of Lighthouse feedback * update test cases
* set coordinated timezone with Contentful of EST * harden specs and formatting refactor
* update cast and crew avatar to real images * update header logo with higher resolution version * add tunesy image for home page greeting * set image height and widths per Lighthouse perf audit * tweak height for mobile * tweak height for mobile * tweak height for mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
N / A
Summary of Changes
TODO