Feature/issue 12 cast and crew #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
help wanted
thescientist13
commented
Oct 9, 2022
|
|
||
| return ` | ||
| <div class="text-center"> | ||
| <img |
There was a problem hiding this comment.
Would probably be good to add loading="lazy" here to these images
This was referenced Oct 9, 2022
thescientist13
added
the
documentation
|
Tracking the image avatar gathers as part of #44 |
thescientist13
force-pushed
the
feature/issue-12-cast-and-crew
branch
from
08af55f to
2d3abfd
Compare
thescientist13
added a commit
that referenced
this pull request
Oct 25, 2022
* initial version of cast and crew section * basic styling and theming of the header * add test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #12
Summary of Changes
CastAndCrewcomponentTODO
Obersavations and tracking items (Help Wanted)
font-familylooks correct in the browser but what's displayed in the browser doesn't look anything like the designs? - typography not rendering correctly #32text-gray-500andrgba(107, 114, 128)part of the design system (theme.css) and document in storybook - Add standards colors to styleguide and apply to project #34