Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: secure_storage.dart #494

Merged
merged 6 commits into from
Sep 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/data/storage/secure_storage.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@ class SecureStorage {
final FlutterSecureStorage _storage;
final Logger _logger;

SecureStorage(this._logger) : _storage = const FlutterSecureStorage();

Future<bool> get hasToken async => await readToken() != null;
const SecureStorage({
required FlutterSecureStorage storage,
required Logger logger,
}) : _storage = storage,
_logger = logger;

Future<void> saveAuthenticatedUser(
String email,
Expand Down
5 changes: 4 additions & 1 deletion lib/service_locator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ import 'package:coffeecard/utils/firebase_analytics_event_logging.dart';
import 'package:coffeecard/utils/ignore_value.dart';
import 'package:coffeecard/utils/reactivation_authenticator.dart';
import 'package:firebase_analytics/firebase_analytics.dart';
import 'package:flutter_secure_storage/flutter_secure_storage.dart';
import 'package:get_it/get_it.dart';
import 'package:logger/logger.dart';

Expand All @@ -75,7 +76,9 @@ void configureServices() {

// Storage
ignoreValue(
sl.registerSingleton(SecureStorage(sl<Logger>())),
sl.registerSingleton(
SecureStorage(storage: const FlutterSecureStorage(), logger: sl()),
),
);

// Authentication
Expand Down
199 changes: 199 additions & 0 deletions test/data/storage/secure_storage_test.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,199 @@
import 'package:coffeecard/data/storage/secure_storage.dart';
import 'package:flutter_secure_storage/flutter_secure_storage.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:logger/logger.dart';
import 'package:mockito/annotations.dart';
import 'package:mockito/mockito.dart';

import 'secure_storage_test.mocks.dart';

@GenerateNiceMocks([MockSpec<FlutterSecureStorage>(), MockSpec<Logger>()])
void main() {
const emailKey = 'email';
const tokenKey = 'authentication_token';
const encodedPasscodeKey = 'encoded_passcode';

late SecureStorage secureStorage;
late MockFlutterSecureStorage mockStorage;
late MockLogger mockLogger;

setUp(() {
mockStorage = MockFlutterSecureStorage();
mockLogger = MockLogger();
secureStorage = SecureStorage(storage: mockStorage, logger: mockLogger);
});

test(
'GIVEN user credentials '
'WHEN saveAuthenticatedUser is called '
'THEN it should save the user credentials to secure storage',
() async {
const email = '[email protected]';
const encodedPasscode = 'encodedPasscode';
const token = 'token';

await secureStorage.saveAuthenticatedUser(
email,
encodedPasscode,
token,
);

verifyInOrder([
mockStorage.write(key: emailKey, value: email),
mockStorage.write(key: encodedPasscodeKey, value: encodedPasscode),
mockStorage.write(key: tokenKey, value: token),
mockLogger.d(any),
]);
},
);

test(
'GIVEN user credentials in secure storage '
'WHEN getAuthenticatedUser is called '
'THEN it should return the authenticated user',
() async {
const email = '[email protected]';
const token = 'token';

when(mockStorage.read(key: emailKey)).thenAnswer((_) async => email);
when(mockStorage.read(key: tokenKey)).thenAnswer((_) async => token);

final user = await secureStorage.getAuthenticatedUser();

expect(user, isNotNull);
expect(user?.email, email);
expect(user?.token, token);
},
);

test(
'GIVEN missing token in secure storage '
'WHEN getAuthenticatedUser is called '
'THEN it should return null',
() async {
const email = '[email protected]';

when(mockStorage.read(key: emailKey)).thenAnswer((_) async => email);
when(mockStorage.read(key: tokenKey)).thenAnswer((_) async => null);

final user = await secureStorage.getAuthenticatedUser();

expect(user, isNull);
},
);

test(
'GIVEN user credentials in secure storage '
'WHEN clearAuthenticatedUser is called '
'THEN it should remove the user credentials from secure storage',
() async {
when(mockStorage.read(key: emailKey))
.thenAnswer((_) async => '[email protected]');
when(mockStorage.read(key: encodedPasscodeKey))
.thenAnswer((_) async => 'encodedPasscode');
when(mockStorage.read(key: tokenKey)).thenAnswer((_) async => 'token');

await secureStorage.clearAuthenticatedUser();

verifyInOrder([
mockStorage.delete(key: emailKey),
mockStorage.delete(key: encodedPasscodeKey),
mockStorage.delete(key: tokenKey),
mockLogger.d(any),
]);
},
);

test(
'GIVEN missing email in secure storage '
'WHEN clearAuthenticatedUser is called '
'THEN it should not remove any user credentials',
() async {
when(mockStorage.read(key: emailKey)).thenAnswer((_) async => null);

await secureStorage.clearAuthenticatedUser();

verifyInOrder([
mockStorage.read(key: emailKey),
mockStorage.read(key: tokenKey),
]);
verifyNever(mockStorage.delete(key: anyNamed('key')));
},
);

test(
'GIVEN a new token '
'WHEN updateToken is called '
'THEN it should update the token in secure storage',
() async {
const token = 'new_token';

await secureStorage.updateToken(token);

verify(mockStorage.write(key: tokenKey, value: token));
verify(mockLogger.d('Token updated in Secure Storage'));
},
);

test(
'GIVEN email stored in secure storage '
'WHEN readEmail is called '
'THEN it should return the email',
() async {
const email = '[email protected]';

when(mockStorage.read(key: emailKey)).thenAnswer((_) async => email);

final result = await secureStorage.readEmail();

expect(result, email);
},
);

test(
'GIVEN encoded passcode stored in secure storage '
'WHEN readEncodedPasscode is called '
'THEN it should return the encoded passcode',
() async {
const encodedPasscode = 'encodedPasscode';

when(mockStorage.read(key: encodedPasscodeKey))
.thenAnswer((_) async => encodedPasscode);

final result = await secureStorage.readEncodedPasscode();

expect(result, encodedPasscode);
},
);

test(
'GIVEN token stored in secure storage '
'WHEN readToken is called '
'THEN it should return the token',
() async {
const token = 'token';

when(mockStorage.read(key: tokenKey)).thenAnswer((_) async => token);

final result = await secureStorage.readToken();

expect(result, token);
},
);

test(
'GIVEN no token or email stored in secure storage '
'WHEN readToken and readEmail are called '
'THEN they should return null',
() async {
when(mockStorage.read(key: emailKey)).thenAnswer((_) async => null);
when(mockStorage.read(key: tokenKey)).thenAnswer((_) async => null);

final email = await secureStorage.readEmail();
final token = await secureStorage.readToken();

expect(email, isNull);
expect(token, isNull);
},
);
}