Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: secure_storage.dart #494

Merged
merged 6 commits into from
Sep 5, 2023
Merged

test: secure_storage.dart #494

merged 6 commits into from
Sep 5, 2023

Conversation

marfavi
Copy link
Member

@marfavi marfavi commented Jun 4, 2023

No description provided.

@ghost
Copy link

ghost commented Jun 4, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@marfavi marfavi requested a review from a team June 4, 2023 11:38
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.24% 🎉

Comparison is base (4aed248) 79.58% compared to head (f352fed) 81.82%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #494      +/-   ##
===========================================
+ Coverage    79.58%   81.82%   +2.24%     
===========================================
  Files          114      114              
  Lines         1195     1194       -1     
===========================================
+ Hits           951      977      +26     
+ Misses         244      217      -27     
Flag Coverage Δ
unittests 81.82% <100.00%> (+2.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/data/storage/secure_storage.dart 100.00% <100.00%> (+100.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TTA777
TTA777 previously requested changes Jun 6, 2023
test/data/storage/secure_storage_test.dart Outdated Show resolved Hide resolved
@marfavi marfavi requested a review from TTA777 June 6, 2023 17:03
@marfavi
Copy link
Member Author

marfavi commented Jun 12, 2023

Re-ran test workflow on latest commit. Proper code coverage numbers are now reported

@marfavi marfavi requested review from a team and removed request for TTA777 August 30, 2023 15:28
@fremartini fremartini merged commit 73585e1 into develop Sep 5, 2023
@fremartini fremartini deleted the test-storage branch September 5, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants