Put React peerDependencies version ranges also on dependencies #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue of having two different versions of React installed if you install React v16 on the app level. Before this change React v15 was always installed by ember-cli-react. Before [email protected] also the installed React version on app level was ignored completely.
levrik
force-pushed
the
react-version-fix
branch
from
86fd375 to
787fd5a
Compare
levrik
changed the title
|
@alexgb Would be awesome to get that merged and released. |
|
I've released version 1.0.2 with this update. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of having two different versions of React installed if you install React v16 on the app level.
Before this change React v15 was always installed by ember-cli-react.
Before [email protected] also the installed React version on app level was ignored completely.