Skip to content

Commit

Permalink
Put React peerDependency version ranges also on dependencies
Browse files Browse the repository at this point in the history
This fixes the issue of having two different versions of React installed if you install React v16 on the app level.
Before this change React v15 was always installed by ember-cli-react.
Before [email protected] also the installed React version on app level was ignored completely.
  • Loading branch information
levrik authored and Levin Rickert committed Oct 5, 2018
1 parent 8aa6874 commit 86fd375
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@
"broccoli-react": "^0.8.0",
"ember-auto-import": "^1.0.1",
"ember-cli-babel": "^6.3.0",
"react": "^15.5.4",
"react-dom": "^15.5.4"
"react": "^15.5.4 || ^16.0.0",
"react-dom": "^15.5.4 || ^16.0.0"
},
"peerDependencies": {
"react": "^15.5.4 || ^16.0.0",
Expand Down

0 comments on commit 86fd375

Please sign in to comment.